[CALCITE-2435] tests: refactor SqlTestFactory #771
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typeFactory is never reused, so the catalog cannot be cached across SqlTestFactory instances
sergeyT2
pushed a commit
to sergeyT2/calcite
that referenced
this pull request
Aug 29, 2018
sergeyT2
pushed a commit
to sergeyT2/calcite
that referenced
this pull request
Aug 29, 2018
F21
pushed a commit
to F21/calcite
that referenced
this pull request
Jan 3, 2019
wangxlong
pushed a commit
to wangxlong/calcite
that referenced
this pull request
Feb 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements https://issues.apache.org/jira/browse/CALCITE-2435
There are three key changes here:
DefaultSqlTestFactorytoSqlTestFactory.SqlTestFactorywas an interface, however it has a single viable implementation, so it makes little sense to keep it as is.MockCatalogReader.initandMockCatalogReader.init2toMockCatalogReaderSimpleandMockCatalogReaderExtendedMockCatalogReaderto its own package, and split several inner classes to a top-level ones.