Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #556, Renamed wrap component to kamelet-reify #557

Merged
merged 1 commit into from
Dec 2, 2020

Conversation

dhirajsb
Copy link
Member

Release Note

Renamed wrap component to kamelet-reify

@lburgazzoli
Copy link
Contributor

@dhirajsb wonder if having kamelet as part of the component name could be misleading (yes I know, wrap is also misleading) as it is true that at the moment the main use case is for kamelts but it is not limited to that context.

@dhirajsb
Copy link
Member Author

@lburgazzoli I did ask for feedback on the name. But, Claus was the only one who responded with a +1, so here we are. 😄

I agree that in principle, the wrap mechanism works in non-kamelet contexts too. Do you foresee it being used for anything else in let's say the next year or two? Even if it is, there is no harm in carrying along the kamelet prefix, sort of an origin story of where this component came from. WDYT?

@dhirajsb
Copy link
Member Author

Also created openshift-integration/kamelet-catalog#9 to use the new scheme name.

@lburgazzoli
Copy link
Contributor

@lburgazzoli I did ask for feedback on the name. But, Claus was the only one who responded with a +1, so here we are. smile

Oh, I've missed it

I agree that in principle, the wrap mechanism works in non-kamelet contexts too. Do you foresee it being used for anything else in let's say the next year or two? Even if it is, there is no harm in carrying along the kamelet prefix, sort of an origin story of where this component came from. WDYT?

I do agree, there's no harm in renaming it as you proposed but to avoid a second rename, let just take one or more days and see if we can find a better name, if not, let's go with kamelet-reify :)

@dhirajsb
Copy link
Member Author

dhirajsb commented Dec 1, 2020

@lburgazzoli were you able to think of something more specific but still generic enough for this component? An alternative I can come up with is delegate, since the component does just that. But it's not any better than wrap to be honest. That's why I originally thought it was better to name it something specific to the immediate purpose it's built to satisfy.

@lburgazzoli
Copy link
Contributor

No, I honestly had no time so I'm ok with this

@nicolaferraro @davsclaus what do you think ?

@davsclaus
Copy link
Contributor

LGTM

@nicolaferraro nicolaferraro merged commit bb4ff0a into apache:master Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants