-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #556, Renamed wrap component to kamelet-reify #557
Conversation
@dhirajsb wonder if having |
@lburgazzoli I did ask for feedback on the name. But, Claus was the only one who responded with a +1, so here we are. 😄 I agree that in principle, the wrap mechanism works in non-kamelet contexts too. Do you foresee it being used for anything else in let's say the next year or two? Even if it is, there is no harm in carrying along the kamelet prefix, sort of an origin story of where this component came from. WDYT? |
Also created openshift-integration/kamelet-catalog#9 to use the new scheme name. |
Oh, I've missed it
I do agree, there's no harm in renaming it as you proposed but to avoid a second rename, let just take one or more days and see if we can find a better name, if not, let's go with |
@lburgazzoli were you able to think of something more specific but still generic enough for this component? An alternative I can come up with is delegate, since the component does just that. But it's not any better than wrap to be honest. That's why I originally thought it was better to name it something specific to the immediate purpose it's built to satisfy. |
No, I honestly had no time so I'm ok with this @nicolaferraro @davsclaus what do you think ? |
LGTM |
Release Note