Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove requirement for PVC on vanilla Kube #1069

Closed
nicolaferraro opened this issue Nov 21, 2019 · 2 comments · Fixed by #1121
Closed

Remove requirement for PVC on vanilla Kube #1069

nicolaferraro opened this issue Nov 21, 2019 · 2 comments · Fixed by #1121
Assignees
Labels
area/build-system Related to the internal image build system kind/feature New feature or request
Milestone

Comments

@nicolaferraro
Copy link
Member

We need a PVC only when caching is enabled, but for normal Kaniko build and push we can initialize the tar.gz in an init-container and then push it to the registry via the Kaniko pod (with data shared using a node local directory volume).

We can also disable image caching by default (caching is a simple but problematic piece, don't really know why). When caching is enabled we can mount the PV for the cache only.

wdyt @astefanutti ?

@nicolaferraro nicolaferraro added kind/feature New feature or request area/build-system Related to the internal image build system labels Nov 21, 2019
@nicolaferraro nicolaferraro added this to the 1.0.0-M5 milestone Nov 21, 2019
@astefanutti
Copy link
Member

I agree Kaniko caching causes too much trouble compared to the benefits. I think the the init container approach makes sense.

@astefanutti astefanutti self-assigned this Nov 21, 2019
@nicolaferraro nicolaferraro modified the milestones: 1.0.0-M5, 1.0.0-CR1 Dec 3, 2019
@astefanutti
Copy link
Member

I've started working on implementing the init container strategy. It's a bit more involved than I anticipated originally as it requires disentangling the scheduling logic from the build logic, and impacts the Build API, but I think it's worth the effort and it will ease supporting Tekton as build strategy eventually (#682).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build-system Related to the internal image build system kind/feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants