Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling traits does not reflect in camel-k integration #1208

Closed
kameshsampath opened this issue Jan 16, 2020 · 1 comment · Fixed by #1215
Closed

Disabling traits does not reflect in camel-k integration #1208

kameshsampath opened this issue Jan 16, 2020 · 1 comment · Fixed by #1215
Milestone

Comments

@kameshsampath
Copy link
Contributor

kameshsampath commented Jan 16, 2020

Platform: minikube 1.6.2
camel-k: 1.0.0.RC1

When we do kamel run with --trait <trait-name>.enabled=false I see the camel logs showing Applying trait

e.g.

kamel run --dependency camel:log --dependency camel:bean get-started/echoer.yaml --trait istio.enabled=false --trait jolokia.enabled=false --trait prometheus.enabled=false
camel-k-operator-5d74595cdf-77gwr camel-k-operator {"level":"info","ts":1579105299.3057547,"logger":"camel-k.trait","msg":"Apply trait: jolokia"}
camel-k-operator-5d74595cdf-77gwr camel-k-operator {"level":"info","ts":1579105299.3057587,"logger":"camel-k.trait","msg":"Apply trait: prometheus"}
@nicolaferraro nicolaferraro added this to the 1.0.0-RC2 milestone Jan 16, 2020
@astefanutti
Copy link
Member

The Jolokia and Prometheus traits are a bit special as they currently rely on the Fabric8 base image behaviour, that activates Jolokia and Prometheus by default. So to de-activate them, the traits have to be applied.

I agree it's counter-intuitive. It will incidentally solved with #394.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants