Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference to IntegrationKit metdata in Builder CR #1299

Closed
lburgazzoli opened this issue Feb 25, 2020 · 1 comment · Fixed by #2131
Closed

Reference to IntegrationKit metdata in Builder CR #1299

lburgazzoli opened this issue Feb 25, 2020 · 1 comment · Fixed by #2131
Assignees
Labels
area/build-operator Related to the internal image build operator kind/task General activity
Milestone

Comments

@lburgazzoli
Copy link
Contributor

lburgazzoli commented Feb 25, 2020

looks like the builder cr stores the metadata from the IntegrationKit in a spec field :

metadata:
  creationTimestamp: 2020-02-25T10:42:40Z
  generation: 1
  labels:
    camel.apache.org/created.by.kind: Integration
    camel.apache.org/created.by.name: simple
    camel.apache.org/created.by.version: "2229"
  name: kit-bpafk8483bbsemjvspv0
  namespace: default
  ownerReferences:
  - apiVersion: camel.apache.org/v1
    blockOwnerDeletion: true
    controller: true
    kind: IntegrationKit
    name: kit-bpafk8483bbsemjvspv0
    uid: 8bd31e83-57bb-11ea-b729-c05ba2de7066
  resourceVersion: "2254"
  selfLink: /apis/camel.apache.org/v1/namespaces/default/builds/kit-bpafk8483bbsemjvspv0
  uid: 8bd9edd4-57bb-11ea-b729-c05ba2de7066
spec:
  tasks:
  - builder:
      baseImage: adoptopenjdk/openjdk8:slim
      buildDir: /builder/kit-bpafk8483bbsemjvspv0
      dependencies:
      - camel:log
      - camel:timer
      - mvn:org.apache.camel.k/camel-k-loader-groovy
      - mvn:org.apache.camel.k/camel-k-runtime-main
      maven:
        localRepository: /tmp/artifacts/m2
        settings:
          configMapKeyRef:
            key: settings.xml
            name: camel-k-maven-settings
        timeout: 3m45s
      meta:
        creationTimestamp: 2020-02-25T10:42:40Z
        generation: 1
        labels:
          camel.apache.org/created.by.kind: Integration
          camel.apache.org/created.by.name: simple
          camel.apache.org/created.by.version: "2229"
          camel.apache.org/kit.type: platform
          camel.apache.org/runtime.provider: main
          camel.apache.org/runtime.version: 1.1.0
        name: kit-bpafk8483bbsemjvspv0
        namespace: default
        resourceVersion: "2235"
        selfLink: /apis/camel.apache.org/v1/namespaces/default/integrationkits/kit-bpafk8483bbsemjvspv0
        uid: 8bd31e83-57bb-11ea-b729-c05ba2de7066

This seems to be used only by the s2i builder as it has not yet been re-factored as a task, once done, we should remove such reference

@lburgazzoli lburgazzoli added the kind/task General activity label Feb 25, 2020
@lburgazzoli
Copy link
Contributor Author

/cc @astefanutti

@lburgazzoli lburgazzoli added this to the 1.0.0 milestone Feb 25, 2020
@nicolaferraro nicolaferraro modified the milestones: 1.0.0, post 1.0.0 May 26, 2020
@astefanutti astefanutti added the area/build-operator Related to the internal image build operator label Jul 21, 2020
@astefanutti astefanutti self-assigned this Jul 21, 2020
@nicolaferraro nicolaferraro modified the milestones: 1.3.0, 1.4.0 Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build-operator Related to the internal image build operator kind/task General activity
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants