Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading error message in knative trait: cannot find event default #1308

Closed
bouskaJ opened this issue Feb 28, 2020 · 2 comments · Fixed by #1619
Closed

Misleading error message in knative trait: cannot find event default #1308

bouskaJ opened this issue Feb 28, 2020 · 2 comments · Fixed by #1619
Labels
good first issue Does not require full understanding of the codebase
Milestone

Comments

@bouskaJ
Copy link
Contributor

bouskaJ commented Feb 28, 2020

I get error during trait customization: cannot find event default","errorVerbose":"cannot find event default error when I run this integration
from('timer:tick') .setBody().constant("Hello 1") .to('knative:event/hello.1')
Without installed broker. (Without knative-eventing-injection=enabled label).
This error message is very misleading and should be changed.

Full log:

{"level":"error","ts":1582883671.1380556,"logger":"controller-runtime.controller","msg":"Reconciler error","controller":"integration-controller","request":"test/knativeevt2","error":"error during trait customization: cannot find event default","errorVerbose":"cannot find event default\ngithub.com/apache/camel-k/pkg/trait.(*knativeTrait).withServiceDo\n\t/go/src/github.com/apache/camel-k/pkg/trait/knative.go:388\ngithub.com/apache/camel-k/pkg/trait.(*knativeTrait).configureEvents\n\t/go/src/github.com/apache/camel-k/pkg/trait/knative.go:298\ngithub.com/apache/camel-k/pkg/trait.(*knativeTrait).Apply\n\t/go/src/github.com/apache/camel-k/pkg/trait/knative.go:182\ngithub.com/apache/camel-k/pkg/trait.(*Catalog).apply\n\t/go/src/github.com/apache/camel-k/pkg/trait/trait_catalog.go:249\ngithub.com/apache/camel-k/pkg/trait.Apply\n\t/go/src/github.com/apache/camel-k/pkg/trait/trait.go:46\ngithub.com/apache/camel-k/pkg/controller/integration.(*deployAction).Handle\n\t/go/src/github.com/apache/camel-k/pkg/controller/integration/deploy.go:56\ngithub.com/apache/camel-k/pkg/controller/integration.(*ReconcileIntegration).Reconcile\n\t/go/src/github.com/apache/camel-k/pkg/controller/integration/integration_controller.go:257\ngithub.com/apache/camel-k/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/go/src/github.com/apache/camel-k/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:256\ngithub.com/apache/camel-k/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/go/src/github.com/apache/camel-k/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:232\ngithub.com/apache/camel-k/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).worker\n\t/go/src/github.com/apache/camel-k/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:211\ngithub.com/apache/camel-k/vendor/k8s.io/apimachinery/pkg/util/wait.JitterUntil.func1\n\t/go/src/github.com/apache/camel-k/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:152\ngithub.com/apache/camel-k/vendor/k8s.io/apimachinery/pkg/util/wait.JitterUntil\n\t/go/src/github.com/apache/camel-k/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:153\ngithub.com/apache/camel-k/vendor/k8s.io/apimachinery/pkg/util/wait.Until\n\t/go/src/github.com/apache/camel-k/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:88\nruntime.goexit\n\t/usr/lib/golang/src/runtime/asm_amd64.s:1357\nerror during trait customization\ngithub.com/apache/camel-k/pkg/trait.Apply\n\t/go/src/github.com/apache/camel-k/pkg/trait/trait.go:47\ngithub.com/apache/camel-k/pkg/controller/integration.(*deployAction).Handle\n\t/go/src/github.com/apache/camel-k/pkg/controller/integration/deploy.go:56\ngithub.com/apache/camel-k/pkg/controller/integration.(*ReconcileIntegration).Reconcile\n\t/go/src/github.com/apache/camel-k/pkg/controller/integration/integration_controller.go:257\ngithub.com/apache/camel-k/vendor/sigs.k8s.io/controller-

This error message is very misleading.

@nicolaferraro nicolaferraro added this to the 1.0.0 milestone Feb 28, 2020
@nicolaferraro nicolaferraro added the good first issue Does not require full understanding of the codebase label Mar 16, 2020
@nicolaferraro nicolaferraro modified the milestones: 1.0.0, post 1.0.0 May 26, 2020
@oscerd
Copy link
Contributor

oscerd commented Jun 15, 2020

This string is not in codebase anymore.

@nicolaferraro
Copy link
Member

This string is not in codebase anymore.

I think it's still there:

return errors.Errorf("cannot find %s %s", serviceType, ref.Name)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Does not require full understanding of the codebase
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants