Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to start Prometheus when Knative enabled. #1459

Closed
weimeilin79 opened this issue May 19, 2020 · 3 comments · Fixed by #1478
Closed

Unable to start Prometheus when Knative enabled. #1459

weimeilin79 opened this issue May 19, 2020 · 3 comments · Fixed by #1478
Assignees
Labels
kind/bug Something isn't working
Milestone

Comments

@weimeilin79
Copy link

Try enable prometheus for a knative service, but had error..

kamel run API.java --open-api openapi.yaml --trait prometheus.enabled=true
Cannot reconcile Integration api: error executing post actions: error during replace resource: could not create or replace resource api: admission webhook "validation.webhook.serving.knative.dev" denied the request: validation failed: Port name prometheus is not allowed: spec.template.spec.containers[0].ports
Name must be empty, or one of: 'h2c', 'http1'
@davsclaus davsclaus added the kind/bug Something isn't working label May 27, 2020
@davsclaus
Copy link
Contributor

@nicolaferraro I think this would be good to get done before GA

@davsclaus davsclaus added this to the 1.0.0 milestone May 27, 2020
@nicolaferraro
Copy link
Member

This is for sure a cool feature, but we need to investigate if it's currently technically possible without changes in Knative, because afaik Knative itself publishes a prometheus endpoint and exposes metrics for their internal prometheus and for the pod autoscaler.

@astefanutti
Copy link
Member

It should be fixed with #1478. I've tested it with Knative auto-scaling:

Screenshot 2020-06-03 at 18 08 17

It shows discontinuities when the integration scales to zero. The metrics are reset per pods, which I think is acceptable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants