Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding camel-jackson dependency creates issues with inner classes #1507

Closed
mmistretta opened this issue Jun 8, 2020 · 5 comments
Closed
Assignees
Milestone

Comments

@mmistretta
Copy link

When adding the camel-jackson dependency, comments with imports, actual imports, etc inner classes are no longer found.

version: Camel K Client and Operator 1.0.0-RC2
Example: https://github.com/jeremyrdavis/quarkus-cafe-demo/commits/camel-k-addition
- commit works: d95b5ea360ca1dabe333b2ce568fc87b18e8594d
- commit does not work: 4ee524f4ccf2c9dce3005b80e7fa44b4d1546528

Process on OpenShift 4.4:

  • Create project
  • Install camel k operator
  • kamel install --olm=false --skip-cluster-setup --skip-operator-setup --maven-repository https://jitpack.io@id=jitpack@snapshots
  • kamel run --name=rest-with-undertow --dependency=camel-rest --dependency=camel-undertow --dependency=mvn:com.github.jeremyrdavis:quarkus-cafe-demo:1.2-SNAPSHOT RestWithUndertow.java
@lburgazzoli
Copy link
Contributor

lburgazzoli commented Jun 10, 2020

This should not be an issue any-more in camel-k 1.0.0

The issues was caused by a bug in the jOOR library which is used to compile the Java integration at runtime which is included in jOOR's 0.9.13 [1]. The camel-k-runtime version used by camel-k RC2 is
1.1.0 [2] which dos not includes the fix [3]

[1] jOOQ/jOOR#99
[2] https://github.com/apache/camel-k/blob/1.0.0-RC2/script/Makefile#L19
[3] https://github.com/apache/camel-k-runtime/blob/camel-k-runtime-parent-1.1.0/pom.xml#L42

@mmistretta can you please confirm ?

@lburgazzoli lburgazzoli added the status/waiting-for-feedback Needs some feedback label Jun 10, 2020
@lburgazzoli lburgazzoli self-assigned this Jun 10, 2020
@mmistretta
Copy link
Author

i used this commit: jeremyrdavis/quarkus-cafe-demo@5e8c7c4
and still get Caused by: java.lang.ClassNotFoundException: RestWithUndertow.GrubHubOrder

@lburgazzoli
Copy link
Contributor

@github-actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity.
Remove stale label or comment or this will be closed in 7 days.

@nicolaferraro nicolaferraro added this to the 1.2.0 milestone Jul 17, 2020
@nicolaferraro nicolaferraro modified the milestones: 1.2.0, 1.3.0 Oct 13, 2020
@nicolaferraro nicolaferraro modified the milestones: 1.3.0, 1.4.0 Dec 22, 2020
@lburgazzoli
Copy link
Contributor

I think we can close this now that we have all the pieces released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants