Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to k8s 0.18.8 #1698

Closed
vaikas opened this issue Sep 10, 2020 · 2 comments
Closed

Update to k8s 0.18.8 #1698

vaikas opened this issue Sep 10, 2020 · 2 comments
Milestone

Comments

@vaikas
Copy link

vaikas commented Sep 10, 2020

As part of the work going on in Knative and moving it to 0.18.8, I'm working on bringing eventing-contrib and as part of that work, looks like we need to bump the versions in this repo as well:

When I update the repo, I unsurprisingly get these kinds of errors:

vaikas-a01:eventing-contrib vaikas$ go test ./camel/...
# github.com/apache/camel-k/pkg/client/camel/clientset/versioned/typed/camel/v1
vendor/github.com/apache/camel-k/pkg/client/camel/clientset/versioned/typed/camel/v1/build.go:75:5: not enough arguments in call to c.client.Get().Namespace(c.ns).Resource("builds").Name(name).VersionedParams(&options, scheme.ParameterCodec).Do
	have ()
	want (context.Context)
vendor/github.com/apache/camel-k/pkg/client/camel/clientset/versioned/typed/camel/v1/build.go:92:5: not enough arguments in call to c.client.Get().Namespace(c.ns).Resource("builds").VersionedParams(&opts, scheme.ParameterCodec).Timeout(timeout).Do
	have ()
	want (context.Context)
vendor/github.com/apache/camel-k/pkg/client/camel/clientset/versioned/typed/camel/v1/build.go:109:8: not enough arguments in call to c.client.Get().Namespace(c.ns).Resource("builds").VersionedParams(&opts, scheme.ParameterCodec).Timeout(timeout).Watch
	have ()
	want (context.Context)

So, before this gets updated we won't be able to move the knative.dev/eventing-contrib forward. @nicolaferraro thoughts? You can see the kinds of changes required (and how to stage them) here:
knative/eventing-contrib#1555

@nicolaferraro nicolaferraro added this to the 1.3.0 milestone Sep 14, 2020
@nicolaferraro
Copy link
Member

For reference, CamelSources are being moved into their own repo under https://github.com/knative-sandbox/eventing-camel.
Adding this to backlog, since an upgrade is needed nonetheless.

@astefanutti
Copy link
Member

astefanutti commented Oct 14, 2020

This has been fixed with #1753 that's included in 1.2.0 release.

@astefanutti astefanutti modified the milestones: 1.3.0, 1.2.0 Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants