Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotrod-client.properties not picked up #1898

Closed
edeandrea opened this issue Jan 11, 2021 · 6 comments
Closed

hotrod-client.properties not picked up #1898

edeandrea opened this issue Jan 11, 2021 · 6 comments

Comments

@edeandrea
Copy link

The hotrod-client.properties file does not seem to be getting picked up when running under quarkus.

In my sample (https://gist.github.com/edeandrea/770c84be9da204ff0b13f2340975904e) I would assume that the properties I have defined in the hotrod-client.properties and are mounted into the Integration would be picked up by the camel:infinispan component, but they are not.

I know this because my hotrod-client.properties file defines infinispan.client.hotrod.marshaller=org.infinispan.commons.marshall.UTF8StringMarshaller. When I run my integration and look into the Infinispan cache, the keys/values that are there aren't simple strings.

@lburgazzoli
Copy link
Contributor

lburgazzoli commented Jan 12, 2021

the hotrod-client.properties is not automatically loaded by camel-k as the config maps are not in the classpath and you should configure quarkus/camel about where to find it similar to what you do with quarkus.infinispan-client.trust-store but it does not look like there is such option in quarkus-infinispan.

For camel it should be something like:

camel.component.infinispan.configuration.configuration-uri = file:{{env:CAMEL_K_MOUNT_PATH_CONFIGMAPS}}/camelk-rhdg-client-confi/hotrod-client.properties

@edeandrea
Copy link
Author

Thanks I'll give this a try. I assume you also have to do whats in #1870, otherwise camel-quarkus does not respect the camel.component.* properties.

@edeandrea
Copy link
Author

the hotrod-client.properties is not automatically loaded by camel-k as the config maps are not in the classpath

Actually in my case the configmap is mounted as a file and is on the classpath.

Would that still not be picked up by camel-k?

@edeandrea
Copy link
Author

edeandrea commented Jan 12, 2021

The problem here is that the Quarkus runtime expects hotrod-client.properties to be in META-INF (see https://github.com/quarkusio/quarkus/blob/master/extensions/infinispan-client/deployment/src/main/java/io/quarkus/infinispan/client/deployment/InfinispanClientProcessor.java#L62). With camel-k, the build is performed by the operator so the user has no way to put hotrod-client.properties inside META-INF. Quarkus should allow configuration of where hotrod-client.properties lives.

There is a discussion on the Quarkus Zulip about this - https://quarkusio.zulipchat.com/#narrow/stream/187030-users/topic/Quarkus.20infinispan.20extension.20hotrod-client.2Eproperties/near/222425566

@edeandrea
Copy link
Author

@lburgazzoli I filed quarkusio/quarkus#14368

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale due to 90 days of inactivity.
It will be closed if no further activity occurs within 15 days.
If you think that’s incorrect or the issue should never stale, please simply write any comment.
Thanks for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants