Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kamelet-binding: improve conditions #2265

Closed
lburgazzoli opened this issue May 5, 2021 · 1 comment
Closed

kamelet-binding: improve conditions #2265

lburgazzoli opened this issue May 5, 2021 · 1 comment

Comments

@lburgazzoli
Copy link
Contributor

The /status/conditions block is very minimalist and does not report much information about the status of the underlying integration:

if it.Status.Phase == v1.IntegrationPhaseRunning {
target.Status.Phase = v1alpha1.KameletBindingPhaseReady
target.Status.SetCondition(
v1alpha1.KameletBindingConditionReady,
corev1.ConditionTrue,
"",
"",
)
} else if it.Status.Phase == v1.IntegrationPhaseError {
target.Status.Phase = v1alpha1.KameletBindingPhaseError
target.Status.SetCondition(
v1alpha1.KameletBindingConditionReady,
corev1.ConditionFalse,
string(target.Status.Phase),
"",
)
} else {
target.Status.Phase = v1alpha1.KameletBindingPhaseCreating
target.Status.SetCondition(
v1alpha1.KameletBindingConditionReady,
corev1.ConditionFalse,
string(target.Status.Phase),
"",
)
}

We should probably have additional phases i.e. Creating, Ready, Error
And we should also report the reason why i.e. an integration has failed.

@lburgazzoli
Copy link
Contributor Author

I think I was quite confused when I opened this issue, let me close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants