Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let dependencies be defined using HTTP URLs #240

Closed
nicolaferraro opened this issue Nov 28, 2018 · 4 comments · Fixed by #3644
Closed

Let dependencies be defined using HTTP URLs #240

nicolaferraro opened this issue Nov 28, 2018 · 4 comments · Fixed by #3644
Labels
good first issue Does not require full understanding of the codebase kind/feature New feature or request
Milestone

Comments

@nicolaferraro
Copy link
Member

We allow mvn: dependencies with camel: and runtime: wrapper. We should allow users to specify HTTP dependencies on libs (to load custom JAR that are not present in Maven central).

@nicolaferraro nicolaferraro added the good first issue Does not require full understanding of the codebase label Nov 28, 2018
@lburgazzoli lburgazzoli added the help wanted Extra attention is needed label Dec 5, 2018
@lburgazzoli lburgazzoli added this to the 1.0.0-RC2 milestone Jan 24, 2020
@nicolaferraro nicolaferraro modified the milestones: 1.0.0-RC2, 1.0.0-future Feb 14, 2020
@nicolaferraro nicolaferraro removed the good first issue Does not require full understanding of the codebase label Mar 26, 2020
@nicolaferraro nicolaferraro modified the milestones: 1.0.0, post 1.0.0 Apr 28, 2020
@nicolaferraro nicolaferraro modified the milestones: 1.3.0, 1.4.0 Dec 22, 2020
@nicolaferraro nicolaferraro modified the milestones: 1.4.0, 1.5.0 Apr 13, 2021
@nicolaferraro nicolaferraro modified the milestones: 1.5.0, 1.6.0 Jul 5, 2021
@squakez
Copy link
Contributor

squakez commented Aug 23, 2021

I am not sure if this is still relevant to these days, as the feature was requested already long time ago. If it's still the case, maybe we can think to upload the dependency on the operator local m2 via [install-file] just the first time we use it. Maybe we can generate some SHA in order to guarantee uniqueness starting from the URI that defines the dependency. The only concern I have is if it makes sense for the operator to host some dependency that could be malicious (altough the same could apply for any mvn dependency I guess).

@nicolaferraro nicolaferraro modified the milestones: 1.6.0, 1.7.0 Sep 7, 2021
@nicolaferraro nicolaferraro modified the milestones: 1.7.0, 1.8.0 Nov 15, 2021
@oscerd oscerd modified the milestones: 1.8.0, 1.9.0 Jan 19, 2022
@oscerd oscerd modified the milestones: 1.9.0, 1.9.1 Apr 26, 2022
@oscerd oscerd modified the milestones: 1.9.1, 1.9.2 May 13, 2022
@oscerd oscerd modified the milestones: 1.9.2, 2.0.0 May 23, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2022

This issue has been automatically marked as stale due to 90 days of inactivity.
It will be closed if no further activity occurs within 15 days.
If you think that’s incorrect or the issue should never stale, please simply write any comment.
Thanks for your contributions!

@squakez
Copy link
Contributor

squakez commented Sep 8, 2022

Managed in #2834

@squakez squakez closed this as completed Sep 8, 2022
@squakez
Copy link
Contributor

squakez commented Sep 8, 2022

I got confused. Now that we have local file dependency in place, we may turn this easily into a new feature that will leverage that development. Ie, we can let the CLI download the http located jar in a temporary file and reference that file such as -d https://my-repo/my-dependency.jar --> -d file:/tmp/my-dependency.jar.

@squakez squakez reopened this Sep 8, 2022
@squakez squakez added kind/feature New feature or request good first issue Does not require full understanding of the codebase and removed status/stale help wanted Extra attention is needed labels Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Does not require full understanding of the codebase kind/feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants