Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kamelet binding annotation should be propagated to the integration #2436

Closed
lburgazzoli opened this issue Jun 23, 2021 · 3 comments
Closed
Milestone

Comments

@lburgazzoli
Copy link
Contributor

I have a KameletBinding create with the following traits configured via annotations

apiVersion: camel.apache.org/v1alpha1
kind: KameletBinding
metadata:
  annotations:
    trait.camel.apache.org/container.image: acme/foo:1.0
    trait.camel.apache.org/kamelet.enabled: "false"

The generated integration does not contain the same annotation, thus the traits are not applied:

apiVersion: camel.apache.org/v1
kind: Integration
metadata:
  name: ce07500532b8b49149fe82cceb8145080
  namespace: bar
spec:
  configuration:
  - type: secret
    value: baz
  flows:
  - from:
      steps:
      - to: kamelet:log-sink/sink
      uri: kamelet:injector-source/source
  profile: Knative
@nicolaferraro nicolaferraro self-assigned this Jun 23, 2021
@nicolaferraro nicolaferraro added this to the 1.5.0 milestone Jun 23, 2021
@tadayosi tadayosi changed the title kamelet biding annotation should be propagated to the integration kamelet binding annotation should be propagated to the integration Jun 28, 2021
@nicolaferraro nicolaferraro modified the milestones: 1.5.0, 1.6.0 Jul 5, 2021
@nicolaferraro nicolaferraro modified the milestones: 1.6.0, 1.7.0 Sep 7, 2021
@nicolaferraro nicolaferraro modified the milestones: 1.7.0, 1.8.0 Nov 15, 2021
@oscerd oscerd modified the milestones: 1.8.0, 1.9.0 Jan 19, 2022
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale due to 90 days of inactivity.
It will be closed if no further activity occurs within 15 days.
If you think that’s incorrect or the issue should never stale, please simply write any comment.
Thanks for your contributions!

@lburgazzoli
Copy link
Contributor Author

@squakez is this still an issue ?

@squakez
Copy link
Contributor

squakez commented Apr 21, 2022

It seems it was fixed. Just tested against 1.8.2 and it forwards annotations.

@squakez squakez closed this as completed Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants