Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of fmt.Print...() methods #2773

Closed
squakez opened this issue Nov 23, 2021 · 8 comments · Fixed by #3153
Closed

Get rid of fmt.Print...() methods #2773

squakez opened this issue Nov 23, 2021 · 8 comments · Fixed by #3153
Assignees
@KuthumiPepple
Labels
good first issue Does not require full understanding of the codebase

Comments

@squakez
Copy link
Contributor

squakez commented Nov 23, 2021

In particular for cmd package, we should redirect the output to the proper output writer.
@squakez squakez added the good first issue Does not require full understanding of the codebase label Feb 15, 2022
@KuthumiPepple
Copy link
Contributor

\assign

@oscerd
Copy link
Contributor

oscerd commented Mar 26, 2022

Assignment is only for reporter or members of Apache organizatiob

@oscerd
Copy link
Contributor

oscerd commented Mar 26, 2022

A comment is enough

@Gre8t
Copy link
Contributor

Gre8t commented Mar 26, 2022

What is the proper output writer? And could this be assigned to me?

@oscerd
Copy link
Contributor

oscerd commented Mar 26, 2022

Assigning issues is reserved to reporter and PMC members. A comment is enough but there is already another person commenting.

@astefanutti
Copy link
Member

@KuthumiPepple to answer your question on the chat, the Cobra command output should be used, which can be retrieved with cmd.OutOrStdout().

@astefanutti
Copy link
Member

@Gre8t feel free to pick another issue labeled "good first issue".

@Gre8t
Copy link
Contributor

Gre8t commented Mar 26, 2022

Thanks @astefanutti, I guess you are my outreachy mentor. Nice to meet you.

@KuthumiPepple KuthumiPepple mentioned this issue Mar 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KuthumiPepple KuthumiPepple

Labels
good first issue Does not require full understanding of the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: redirect ouput and errors to appropriate writer KuthumiPepple/camel-k
5 participants
@astefanutti @oscerd @Gre8t @squakez @KuthumiPepple