Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choose a single location for examples #2826

Closed
oscerd opened this issue Dec 9, 2021 · 11 comments
Closed

Choose a single location for examples #2826

oscerd opened this issue Dec 9, 2021 · 11 comments
Assignees

Comments

@oscerd
Copy link
Contributor

oscerd commented Dec 9, 2021

We had some discussion here: #2731

I think it's important to have a single location for examples, because it would be much easier to maintain and also we could be able to tag them without having the camel-k release enriched with examples.

My vote is to move all the examples in the https://github.com/apache/camel-k-examples repository

But I'd like to get more feedback and votes.

@squakez
Copy link
Contributor

squakez commented Dec 9, 2021

Yes, it was something I planned to do in the past, but went out of my radar (#2462). As mentioned in that discussion, I am good with moving everything in the dedicated repository. In that case, I suggest we apply the same branching strategy of the main project.

@oscerd oscerd self-assigned this Dec 9, 2021
@oscerd
Copy link
Contributor Author

oscerd commented Dec 9, 2021

Ok, I'm going to work on this.

@astefanutti
Copy link
Member

It sounds good to me. Having the examples promoted into their own repository will certainly make them more visible. Possibly, it'll even make things easier to setup automated testing and foster test coverage in this new repository.

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale due to 90 days of inactivity.
It will be closed if no further activity occurs within 15 days.
If you think that’s incorrect or the issue should never stale, please simply write any comment.
Thanks for your contributions!

@oscerd
Copy link
Contributor Author

oscerd commented Apr 7, 2022

Do we still want to move everything in a different repository?

@squakez
Copy link
Contributor

squakez commented Apr 7, 2022

+1 for me. We can link the example folder to the new location.

@oscerd
Copy link
Contributor Author

oscerd commented Apr 21, 2022

The examples are now in https://github.com/apache/camel-k-examples/tree/main/generic-examples

I'll see how to remove the examples from the main folder once we released 1.9.0

@squakez
Copy link
Contributor

squakez commented Apr 22, 2022

Great, thanks @oscerd ! I wonder if we should also remove the CamelSource examples.

@oscerd
Copy link
Contributor Author

oscerd commented Apr 22, 2022

Where are them?

@squakez
Copy link
Contributor

squakez commented Apr 22, 2022

Where are them?

This one for instance: https://github.com/apache/camel-k-examples/tree/main/04-aws-kinesis-source-basic

@oscerd
Copy link
Contributor Author

oscerd commented Apr 22, 2022

Yeah, I think we need to focus on kamelets and generic-examples.

@squakez squakez closed this as completed Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants