Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Camel 3.15 - Data formats renamed #2880

Closed
davsclaus opened this issue Jan 17, 2022 · 7 comments
Closed

Camel 3.15 - Data formats renamed #2880

davsclaus opened this issue Jan 17, 2022 · 7 comments

Comments

@davsclaus
Copy link
Contributor

See ticket
apache/camel-quarkus#3460

This means that the algorithm in camel-k that detects camel components (in this case data formats) may need to be changed due to the renamed names.

@davsclaus
Copy link
Contributor Author

The camel-k catalog needs to be updated / rebuild as it uses the old names - eg if you do a

git grep "jacksonxml"
git grep "mime-multipart"

@astefanutti
Copy link
Member

Is the list from https://github.com/apache/camel/blob/main/docs/user-manual/modules/ROOT/pages/camel-3x-upgrade-guide-3_15.adoc#data-formats exhaustive, or these are examples?

I'm asking because there are a number of kebab-cased references in the current CamelCatalog resource based on Camel 3.12.0, like json-jackson, protobuf-jackson, avro-jackson, json-johnzon, json-jsonb, mime-multipart, yaml-snakeyaml, ... that are not in that list. That being said, I expect the name changes to be picked up automatically once we regenerate the CamelCatalog. But there is some hard-coding for json-jackson and the marshal DSL to JSON.

@davsclaus
Copy link
Contributor Author

The list is exhaustive .. so far

Those json (also bindy, avro, protobuf) are more tricky as they are some kind of weird variant in the model and maven plugins we use to generate metadata. All of that needs to be adjusted to migrate and its a bigger effort.

So when Camel 3.15 is upgraded in camel quarkus and camel-k is ready to use this, then check the list and see what the status is

@astefanutti
Copy link
Member

Great, regenerating the CamelCatalog resource should be enough in that case then.

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale due to 90 days of inactivity.
It will be closed if no further activity occurs within 15 days.
If you think that’s incorrect or the issue should never stale, please simply write any comment.
Thanks for your contributions!

@squakez
Copy link
Contributor

squakez commented Apr 18, 2022

Ref #3213

@tadayosi
Copy link
Member

I assume it's already done, so let me close it. Please reopen if I'm wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants