Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kamel kit create to use mount/camel traits #2915

Closed
squakez opened this issue Jan 24, 2022 · 5 comments
Closed

Kamel kit create to use mount/camel traits #2915

squakez opened this issue Jan 24, 2022 · 5 comments
Labels
good first issue Does not require full understanding of the codebase

Comments

@squakez
Copy link
Contributor

squakez commented Jan 24, 2022

The command still use properties/configmap/secret parameters https://github.com/apache/camel-k/blob/main/pkg/cmd/kit_create.go#L70-L72 and they could instead use the logic encapsulated in camel trait (for properties) and mount trait (for configmap/secret).
@squakez squakez added the good first issue Does not require full understanding of the codebase label Feb 15, 2022
@Gre8t
Copy link
Contributor

Gre8t commented Apr 2, 2022

Hi, could this be assigned to me?

@Gre8t
Copy link
Contributor

Gre8t commented Apr 2, 2022

I fixed this issue in pr #3160

@KuthumiPepple
Copy link
Contributor

I'd like to work on this if it's not assigned to anyone yet

@squakez
Copy link
Contributor Author

squakez commented Apr 12, 2022

I can see @Gre8t was working on it

@Gre8t
Copy link
Contributor

Gre8t commented Apr 25, 2022

hi @squakez this issue is resolved in pr #3160

@squakez squakez closed this as completed Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Does not require full understanding of the codebase
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Gre8t @squakez @KuthumiPepple