Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nightly builds in test docker repo #3106

Closed
squakez opened this issue Mar 10, 2022 · 15 comments
Closed

Nightly builds in test docker repo #3106

squakez opened this issue Mar 10, 2022 · 15 comments
Assignees
Labels
area/continuous integration Related to CI and automated testing kind/task General activity

Comments

@squakez
Copy link
Contributor

squakez commented Mar 10, 2022

I'm recovering the nightly builds and I've noticed we're publishing them into some testcamelk/camel-k repository (see https://hub.docker.com/r/testcamelk/camel-k/tags). I wonder if we should instead use the official repo (apache/camel-k). I don't know if there is any policy limitation though from the foundation.

Then, another thing I noticed is that we are not using latest tag at all. I think we should label the latest stable release with this tag as well.

@astefanutti @oscerd @lburgazzoli any thought?

@squakez squakez added area/continuous integration Related to CI and automated testing kind/question Further information is requested labels Mar 10, 2022
@oscerd
Copy link
Contributor

oscerd commented Mar 10, 2022

we are using camelk/camelk for stagin docker image while releasing and testcamelk sounds new to me. I think we should avoid placing multiple tags in the official apache camelk repository on docker hub. So I would rather place the nightly in camelk/camelk.

@oscerd
Copy link
Contributor

oscerd commented Mar 10, 2022

Let's wait for other feedback btw.

@squakez
Copy link
Contributor Author

squakez commented Mar 15, 2022

Thanks @oscerd. I've managed to setup a single nightly release which is pushing to testcamelk repo. That configuration is taken from some organization secret (see https://github.com/apache/camel-k/blob/main/.github/workflows/release.yml#L52-L53). Can you please tell me if we have the equivalent for camelk/camelk staging as you were suggesting? replacing that should be enough to publish the nightly in the staging repo.

@oscerd
Copy link
Contributor

oscerd commented Mar 15, 2022

I don't think we have something like that for camelk/camelk. We need @nicolaferraro for this purpose, because he set up the original account.

@astefanutti
Copy link
Member

@oscerd Now that we have a single rolling tag, would that be acceptable to push it in apache/camel-k? That may not be obvious for users that camelk/camelk is legit, and requires the prudent ones to do their own research to assess whether it's fishy or not.

@oscerd
Copy link
Contributor

oscerd commented Mar 15, 2022

Yes, it makes sense totally sense now.

@squakez
Copy link
Contributor Author

squakez commented Mar 15, 2022

Do we already have the secret configured for that account?

@squakez
Copy link
Contributor Author

squakez commented Mar 15, 2022

@oscerd is it something already present in the setting of the project as it happens for TEST_DOCKER_HUB_USERNAME? Thanks.

@oscerd
Copy link
Contributor

oscerd commented Mar 15, 2022

As far as I know no. The only case when we push on docker is when we release.. so it is done with personal accounts. We ask Infra to enable some accounts of the PMC.

@squakez
Copy link
Contributor Author

squakez commented Mar 16, 2022

Great, thanks. Let me know when we have any news so we I can do the needed changes. In the while we can use the testing docker hub. I've just checked and it replaces correctly the image.

@squakez squakez self-assigned this Mar 16, 2022
@squakez squakez added kind/task General activity and removed kind/question Further information is requested labels Mar 21, 2022
@squakez
Copy link
Contributor Author

squakez commented Mar 21, 2022

Hi @oscerd can I ask you if you have any update on this one? Thanks in advance.

@oscerd
Copy link
Contributor

oscerd commented Mar 21, 2022

I didn't ask to Infra. I would probably first ask to @zregvart because he's the expert about Infra and credentials.

@zregvart
Copy link
Member

There are some notes on this towards the bottom of this document.
The ASF policy allows distribution of compiled binaries, for end user convenience. For snapshot builds we need to carefully steer end users away as they are not official voted-upon releases, so make sure to indicate that these are only for development/testing.

@squakez
Copy link
Contributor Author

squakez commented Mar 22, 2022

There are some notes on this towards the bottom of this document. The ASF policy allows distribution of compiled binaries, for end user convenience. For snapshot builds we need to carefully steer end users away as they are not official voted-upon releases, so make sure to indicate that these are only for development/testing.

Thanks @zregvart . I see in the example it mentions the usage of certain secrets (DOCKERHUB_USER and token DOCKERHUB_TOKEN), but they must be provided in the configuration setting. As I understand from a previous comment from @oscerd, we don't have them set. The official release process is done with personal user accounts, so, if we want to proceed ahead we will need to ask those credentials.

@squakez
Copy link
Contributor Author

squakez commented May 6, 2022

I've provided some detail in the release notes to let people know the test account is the one we use. We can keep it as it is I guess.

@squakez squakez closed this as completed May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/continuous integration Related to CI and automated testing kind/task General activity
Projects
None yet
Development

No branches or pull requests

4 participants