Should make bundle update kustomization.yaml?

[squakez]

As discussed in #3601 (comment) the make bundle is adding images property. Is that correct?

[squakez]

Can you help @phantomjinx ?

[phantomjinx]

So, the changes should not be committed.

1. The changes are transient to the kustomization config files
2. A user is able to make use of these files without using our Makefiles by adding in their own references to the image and tag.

So the base version of the files remain under source control, while the changes come and go depending on user edits or executing make clean bundle. If I could gitignore them I would.

[tadayosi]

Yes, I think so too. This is the most itchy part of kustomize for me. The kustomize developers has deliberately chosen that user-customised changes are directly applied to the kustomization.yaml file. And there seems to be no way to parameterise user configs other than tainting kustomization.yaml:
https://kubectl.docs.kubernetes.io/faq/kustomize/eschewedfeatures/#build-time-side-effects-from-cli-args-or-env-variables

[phantomjinx]

Can this be closed as asked and answered?