Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review reset and delete with --all option for merging similar functions to one place #598

Closed
dmvolod opened this issue Apr 9, 2019 · 1 comment
Closed

Review reset and delete with --all option for merging similar functions to one place #598

dmvolod opened this issue Apr 9, 2019 · 1 comment

Comments

@dmvolod
Copy link
Member

dmvolod commented Apr 9, 2019

As pkg/cmd/reset.go and pkg/cmd/delete.go contains both code for deleting all integrations it would be nice to merge common code to one place and details explain delete vs reset in these context.
I will take care about this.
@dmvolod dmvolod changed the title Review reset and delete with --all option for merging similar functions to one package Review reset and delete with --all option for merging similar functions to one place Apr 9, 2019
@dmvolod
Copy link
Member Author

dmvolod commented Apr 10, 2019

@nicolaferraro , @lburgazzoli is reset could be similar to delete --all or we need a separate functions with just delete integrations and delete integrations with them context in reset?

@dmvolod dmvolod closed this as completed Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dmvolod