Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle defaults differently (aka do not change specs) #778

Closed
nicolaferraro opened this issue Jun 26, 2019 · 3 comments
Closed

Handle defaults differently (aka do not change specs) #778

nicolaferraro opened this issue Jun 26, 2019 · 3 comments
Labels
kind/bug Something isn't working
Milestone

Comments

@nicolaferraro
Copy link
Member

I'm working on upgrades and I think we have a issue with defaults.

We use the integrationplatform as global config location and if a property is not set on the platform, we set its default value in the spec during the "initialize" phase.

E.g. when initializing a empty integrationplatform we set runtimeVersion to 0.3.3

But if we upgrade Camel K to a version that uses runtimeVersion 1.0.0 by default, we can't tell if that 0.3.3 was set by the user or was a default value added by the previous release.

We should compute defaults without writing them into the spec field.

@nicolaferraro nicolaferraro added the kind/bug Something isn't working label Jun 26, 2019
@nicolaferraro nicolaferraro added this to the 1.0.0 milestone Jun 26, 2019
@lburgazzoli
Copy link
Contributor

We can put them in the status and reset them on platform re-initialization ? having the default visible is quite useful (imho)

@nicolaferraro
Copy link
Member Author

Yeah.. or I remember some tool that was writing the "applied configuration" in an annotation.. status is cleaner of course

@nicolaferraro
Copy link
Member Author

Fixed by #1127

@nicolaferraro nicolaferraro modified the milestones: 1.0.0, 1.0.0-RC2 Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants