Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[camel-main-support] Use camel's built-in support for configuring data formats trough properties #497

Closed
lburgazzoli opened this issue Oct 2, 2020 · 2 comments
Assignees
Labels
Milestone

Comments

@lburgazzoli
Copy link
Contributor

Configuring dataformat is done via a custom logic but Camel has built in support for configuring data formats from properties using Camel Main so this code:

    case MARSHALL:                            
        camel.getRegistry().bind(dataformatId, lookupAndInstantiateDataformat(dataformatId));
        rd.marshal().custom(dataformatId);
        break;

can be replaced by:

    case MARSHALL:
        rd.marshal(dataformatId)
        break;

NOTE: requires camel 3.6.x

@lburgazzoli
Copy link
Contributor Author

/cc @valdar

@valdar valdar self-assigned this Oct 2, 2020
@lburgazzoli lburgazzoli changed the title Use camel's built-in support for configuring data formats tjrough properties [camel-main-support] Use camel's built-in support for configuring data formats tjrough properties Oct 2, 2020
@valdar valdar changed the title [camel-main-support] Use camel's built-in support for configuring data formats tjrough properties [camel-main-support] Use camel's built-in support for configuring data formats trough properties Oct 6, 2020
lburgazzoli added a commit to lburgazzoli/apache-camel-kafka-connector that referenced this issue Oct 9, 2020
lburgazzoli added a commit to lburgazzoli/apache-camel-kafka-connector that referenced this issue Oct 9, 2020
@lburgazzoli
Copy link
Contributor Author

Fixed with #556

@oscerd oscerd added this to the 0.7.0 milestone Jan 29, 2021
@oscerd oscerd added the 0.7.0 label Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants