Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validator script to use template in favour of flow #751

Closed
squakez opened this issue Jan 27, 2022 · 1 comment · Fixed by #752
Closed

Validator script to use template in favour of flow #751

squakez opened this issue Jan 27, 2022 · 1 comment · Fixed by #752
Assignees
@squakez
Labels
bug Something isn't working

Comments

@squakez
Copy link
Contributor

squakez commented Jan 27, 2022

The script we use to validate a Kamelet should remove the deprecated flow in favour of template: https://github.com/apache/camel-kamelets/blob/main/script/validator/validator.go
@squakez squakez self-assigned this Jan 27, 2022
@squakez squakez mentioned this issue Jan 27, 2022
Merged
@squakez
Copy link
Contributor Author

squakez commented Jan 27, 2022

We're not even validating the Kamelets at each PR: https://github.com/apache/camel-kamelets/blob/main/.github/workflows/validate.yaml#L58 - to be fixed as well

@squakez squakez added the bug Something isn't working label Jan 27, 2022
@squakez squakez mentioned this issue Jan 27, 2022
Merged
squakez added a commit that referenced this issue Jan 28, 2022
@squakez
fix(ci): validate kamelets directory
64fd5fb 
Also changed the validator to warn if deprecated .kamelet.spec.flow is found

Closes #751
@squakez squakez mentioned this issue Jan 28, 2022
Merged
squakez added a commit that referenced this issue Jan 28, 2022
@squakez
fix(ci): validate kamelets directory
8eafef6 
Also changed the validator to warn if deprecated .kamelet.spec.flow is found

Closes #751
squakez added a commit that referenced this issue Jan 28, 2022
@squakez
fix(ci): validate kamelets directory
756d387 
Also changed the validator to warn if deprecated .kamelet.spec.flow is found

Closes #751
squakez added a commit that referenced this issue Jan 31, 2022
@squakez
fix(ci): validate kamelets directory
37650f1 
Also changed the validator to warn if deprecated .kamelet.spec.flow is found

Closes #751
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@squakez squakez

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ci): validate kamelets directory apache/camel-kamelets
1 participant
@squakez