Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move deprecated flow to template #750

Merged
merged 1 commit into from
Jan 28, 2022
Merged

chore: move deprecated flow to template #750

merged 1 commit into from
Jan 28, 2022

Conversation

squakez
Copy link
Contributor

@squakez squakez commented Jan 27, 2022

This PR span over all the list of Kamelets as we've deprecated since a while .spec.flow parameter in favour of .spec.template. apache/camel-k#2932 will remove it from next camel-k spec (1.9), so we must apply this change before that PR is merged as well.

@squakez squakez requested a review from oscerd January 27, 2022 14:48
@squakez
Copy link
Contributor Author

squakez commented Jan 27, 2022

By the way, I'm not sure if there is any other documentation, apart the autogenerated one from the same sources.

@squakez
Copy link
Contributor Author

squakez commented Jan 27, 2022

The validation is failing #751. Will need to fix it along this PR.

@djencks
Copy link
Contributor

djencks commented Jan 27, 2022

At least https://camel.apache.org/camel-k/next/kamelets/kamelets-dev.html has flow in the samples. I didn't look in your other PRs, I'll plan to fix this if you haven't.
... I see you already fixed this in the camel-k PR.

Copy link
Contributor

@oscerd oscerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing we could do is pointing the camel dependencies to 3.15.0-SNAPSHOT in library and everywhere else on main branch, otherwise this may create confusion

@oscerd
Copy link
Contributor

oscerd commented Jan 28, 2022

Let's merge this one for beginning.

@oscerd oscerd merged commit 8926068 into main Jan 28, 2022
@oscerd
Copy link
Contributor

oscerd commented Jan 28, 2022

Sorry I had to revert. We have multiple place where we need to address this:

  • the catalog is using the camel-k extension from fabric8 kubernetes-client and there is no trace of spec.template directly there
  • the validator needs to point to an updated model for camel-k crd etc. and still we cannot use it
  • in this situation test on catalog will fail, validation will fail etc.
  • We could leave the PR open @squakez and wait for a more stable situation for updating main here, can you place create a new PR? Thanks and sorry

@squakez
Copy link
Contributor Author

squakez commented Jan 28, 2022

No problem. I was planning to close it anyway or rebase after #751 is fixed.

@oscerd oscerd deleted the chore/flow_template branch March 9, 2022 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants