Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide how to maintain examples #118

Closed
ppalaga opened this issue Aug 8, 2019 · 4 comments · Fixed by #238
Closed

Decide how to maintain examples #118

ppalaga opened this issue Aug 8, 2019 · 4 comments · Fixed by #238

Comments

@ppalaga
Copy link
Contributor

ppalaga commented Aug 8, 2019

Followup of the discussion in #112 and #115

What we agreed upon with @lburgazzoli :

  • We need examples
  • Integration tests may test aspects that have no didactic value for the app developers so keeping the distinction between itests and examples makes sense
  • Examples should have tests

Open questions:

  1. Where should the examples be hosted? camel-quarkus (preferred by @ppalaga ) or elsewhere?

  2. Should the tests in example projects be run for every PR in camel-quarkus?

  • @ppalaga: yes definitely, to have a tight feedback and responsibility loop
  • @lburgazzoli: no daily is enough, otherwise the CI would take long
@lburgazzoli
Copy link
Contributor

@ppalaga would be ok to test examples in jvm mode and native daily ? I'm also ok to build everything every time but I remember you were concerned about build taking too long so if you are fine, I'm fine too

@ppalaga
Copy link
Contributor Author

ppalaga commented Aug 13, 2019

OK, sounds like we agree about 1.: the examples should live in camel-quarkus git repo, in an new directory called examples.

For 2: Yes, I have the concerns about the build times. That's why I hold the view that we should avoid having similar projects in itests and examples. I prefer starting with testing the native mode in examples on every PR and I am open to revisit this when we feel the builds take too long.

@kameshsampath
Copy link

@ppalaga @lburgazzoli - I will try to add few examples based on https://github.com/apache/camel/tree/master/examples and see how many i can migrate as few components might need quarkizing

@davsclaus
Copy link
Contributor

It would be good to get a few basic examples added soon so when we do releases we can point new users to this so they can easily see how to use camel and quarkus, and also that they can quickly try out themselves

@ppalaga ppalaga added this to the No fix/wont't fix milestone Mar 26, 2021
ppalaga pushed a commit to ppalaga/camel-quarkus that referenced this issue Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants