Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

main: add an option to ignore command line arguments #2293

Closed
lburgazzoli opened this issue Mar 1, 2021 · 3 comments
Closed

main: add an option to ignore command line arguments #2293

lburgazzoli opened this issue Mar 1, 2021 · 3 comments
Assignees
Milestone

Comments

@lburgazzoli
Copy link
Contributor

If you run a camel quarkus application with camel-quarkus-main then it will intercept the command line arguments and eventually fail if as example, some parameter are unknown to camel-main.

We should make this behavior optional or find a better way to handle command line option, i.e. not to fail if an option is unknown.

@ppalaga
Copy link
Contributor

ppalaga commented Mar 12, 2021

Related quarkusio/quarkus#15416

@ppalaga
Copy link
Contributor

ppalaga commented Mar 12, 2021

There are two workarounds for the wrong ordering of -jar and -cp args by the quarkus-openshift extension:

  • Set quarkus.package.type=uber-jar will avoid adding the -cp arg. This works on Quarkus 1.12+ thanks to https://github.com/quarkusio/quarkus/pull/15076/files
  • Copy the generated resources from target/kubernetes to src/main/kubernetes and remove the -cp argument there.

@jamesnetherton jamesnetherton self-assigned this Mar 15, 2021
jamesnetherton added a commit to jamesnetherton/camel-quarkus that referenced this issue Mar 16, 2021
jamesnetherton added a commit to jamesnetherton/camel-quarkus that referenced this issue Mar 16, 2021
jamesnetherton added a commit to jamesnetherton/camel-quarkus that referenced this issue Mar 16, 2021
jamesnetherton added a commit to jboss-fuse/camel-quarkus that referenced this issue Mar 16, 2021
@jamesnetherton
Copy link
Contributor

Need to reopen this as the original fix isn't quite right. The call to completed() in parseArguments() should only happen if the failure remedy is fail. Otherwise the Camel application is prematurely terminated.

jamesnetherton added a commit to jamesnetherton/camel-quarkus that referenced this issue Mar 24, 2021
jamesnetherton added a commit to jamesnetherton/camel-quarkus that referenced this issue Mar 24, 2021
jamesnetherton added a commit to jamesnetherton/camel-quarkus that referenced this issue Mar 25, 2021
jamesnetherton added a commit to jboss-fuse/camel-quarkus that referenced this issue Mar 25, 2021
@jamesnetherton jamesnetherton added this to the 1.8.0 milestone Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants