Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messaging integration test for JMS topics is not working #2608

Closed
jamesnetherton opened this issue May 18, 2021 · 6 comments
Closed

Messaging integration test for JMS topics is not working #2608

jamesnetherton opened this issue May 18, 2021 · 6 comments
Assignees
Labels
Milestone

Comments

@jamesnetherton
Copy link
Contributor

Turns out that topics have not actually ever been tested properly. The JAX-RS resource method for the test is missing an @Consumes annotation which seems to prevent the logic from being triggered.

However, when adding this, the tests fail anyway and I couldn't track down what the cause of the issue is after a quick investigation.

Not sure if it's related to the dockerized Artemis instance configuration in some way. Since we're using an out-of-date & deprecated image, perhaps we should use the EmbeddedActiveMQ in ActiveMQTestResource? We could inherit artemis-server from the quarkus-bom and that way we don't have to worry about additional maintenance on our side.

@jamesnetherton
Copy link
Contributor Author

@zhfeng Would you be able to take a look at this?

@zhfeng
Copy link
Contributor

zhfeng commented May 18, 2021

@jamesnetherton yeah, please assign to me.

@ppalaga ppalaga added this to the 2.0.0 milestone May 26, 2021
@zhfeng
Copy link
Contributor

zhfeng commented Jun 3, 2021

I'd tried to use EmbeddedActiveMQ but it did not resolve the issue. Only one endpoint of the topic receives a message. I will keep investigating.

zhfeng added a commit to zhfeng/camel-quarkus that referenced this issue Jun 4, 2021
@zhfeng
Copy link
Contributor

zhfeng commented Jun 4, 2021

@jamesnetherton I think I get the root cause of the issue which we can not reslove the destination name correcly and always use createQueue. It could be better to raise a other issue to replace the out-of-date docker artemis image with EmbeddedActiveMQ from artemis-server.

@jamesnetherton
Copy link
Contributor Author

I completely forgot about the custom destination resolver. Thanks for fixing it @zhfeng!

We can take care of the docker image in another issue.

@zhfeng
Copy link
Contributor

zhfeng commented Jun 4, 2021

yeah, I raise #2727 and I can take a look since this image has also been used in jta integration tests.

@ppalaga ppalaga closed this as completed in 8868834 Jun 4, 2021
@ppalaga ppalaga modified the milestones: 2.0.0, 2.0.0-M2 Jun 4, 2021
jamesnetherton pushed a commit to jboss-fuse/camel-quarkus that referenced this issue Jun 7, 2021
jamesnetherton pushed a commit to jboss-fuse/camel-quarkus that referenced this issue Jun 7, 2021
jamesnetherton pushed a commit to jboss-fuse/camel-quarkus that referenced this issue Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants