Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use EmbeddedActiveMQ in messaging and jta integration tests #2727

Closed
zhfeng opened this issue Jun 4, 2021 · 5 comments
Closed

Use EmbeddedActiveMQ in messaging and jta integration tests #2727

zhfeng opened this issue Jun 4, 2021 · 5 comments
Milestone
2.0.0

Comments

@zhfeng
Copy link
Contributor

zhfeng commented Jun 4, 2021

Since we're using an out-of-date & deprecated image, we should use the EmbeddedActiveMQ in ActiveMQTestResource and could inherit artemis-server from the quarkus-bom and that way we don't have to worry about additional maintenance on our side.
@zhfeng zhfeng mentioned this issue Jun 4, 2021
Closed
@zhfeng
Copy link
Contributor Author

zhfeng commented Jun 7, 2021

The quarkus bom does not include org.apache.activemq:artemis-mqtt-protocol, so I just raise quarkusio/quarkus#17720 to add it. All the tests should be OK.

@ppalaga
Copy link
Contributor

ppalaga commented Jun 7, 2021

quarkusio/quarkus#17721 was merged.

@ppalaga ppalaga added this to the 2.0.0 milestone Jun 7, 2021
@zhfeng
Copy link
Contributor Author

zhfeng commented Jun 8, 2021

Great - and is it possible to take these changes to quakrus-main branch first to see if it works ? But I find the "Daily Build Quarkus main" is still failing.

zhfeng added a commit to zhfeng/camel-quarkus that referenced this issue Jun 8, 2021
@zhfeng
Fix apache#2727 to use embeddedActiveMQ for messageing and jta integr…
a66707e 
…ation tests
zhfeng added a commit to zhfeng/camel-quarkus that referenced this issue Jun 8, 2021
@zhfeng
Fix apache#2727 to use embeddedActiveMQ for messageing and jta integr…
1dd1461 
…ation tests
zhfeng added a commit to zhfeng/camel-quarkus that referenced this issue Jun 8, 2021
@zhfeng
Fix apache#2727 to use embeddedActiveMQ for messageing and jta integr…
6f581ce 
…ation tests
@ppalaga
Copy link
Contributor

ppalaga commented Jun 8, 2021

Great - and is it possible to take these changes to quakrus-main branch first to see if it works ?

Yes, please feel free to send a pull request against quarkus-main

But I find the "Daily Build Quarkus main" is still failing.

Sorry about that, it is was my fault. I have fixed the branch now.

zhfeng added a commit to zhfeng/camel-quarkus that referenced this issue Jun 9, 2021
@zhfeng
Fix apache#2727 to use embeddedActiveMQ for messageing and jta integr…
85bfebf 
…ation tests
zhfeng added a commit to zhfeng/camel-quarkus that referenced this issue Jun 11, 2021
@zhfeng
Fix apache#2727 to use embeddedActiveMQ for messageing and jta integr…
f0188ae 
…ation tests
zhfeng added a commit to zhfeng/camel-quarkus that referenced this issue Jun 11, 2021
@zhfeng
Fix apache#2727 to use embeddedActiveMQ for messageing and jta integr…
2c84a2a 
…ation tests
zhfeng added a commit to zhfeng/camel-quarkus that referenced this issue Jun 16, 2021
@zhfeng
Fix apache#2727 to use embeddedActiveMQ for messageing and jta integr…
a4bbd38 
…ation tests
zhfeng added a commit to zhfeng/camel-quarkus that referenced this issue Jun 21, 2021
@zhfeng
Fix apache#2727 to use embeddedActiveMQ for messageing and jta integr…
f014011 
…ation tests
ppalaga pushed a commit that referenced this issue Jun 21, 2021
@zhfeng @ppalaga
Fix #2727 to use embeddedActiveMQ for messageing and jta integration …
5273d4b 
…tests
@ppalaga
Copy link
Contributor

ppalaga commented Jun 21, 2021

#2751 was cherry-picked to quarkus-main

@ppalaga ppalaga mentioned this issue Jun 21, 2021
Closed
ppalaga pushed a commit that referenced this issue Jun 23, 2021
@zhfeng @ppalaga
Fix #2727 to use embeddedActiveMQ for messageing and jta integration …
526e32f 
…tests
ppalaga pushed a commit that referenced this issue Jun 23, 2021
@zhfeng @ppalaga
Fix #2727 to use embeddedActiveMQ for messageing and jta integration …
962097e 
…tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
2 participants
@zhfeng @ppalaga