Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Quarkus 2.5.0] Kafka SASL / SSL tests are failing #3239

Closed
jamesnetherton opened this issue Oct 27, 2021 · 5 comments
Closed

[Quarkus 2.5.0] Kafka SASL / SSL tests are failing #3239

jamesnetherton opened this issue Oct 27, 2021 · 5 comments
Assignees

Comments

@jamesnetherton
Copy link
Contributor

jamesnetherton commented Oct 27, 2021

Needs investigating properly, but I don't think the custom configs to apply the necessary security bits to the Kafka broker are working. It may be related to the testcontainers version bump from 1.16.0 to 1.16.2.

I'm disabling the tests for now.

@zhfeng
Copy link
Contributor

zhfeng commented Nov 1, 2021

@jamesnetherton I think you are right. This is related to testcontainers 1.6.2 changes with

https://github.com/testcontainers/testcontainers-java/blob/4df9b900e79e4a3033ef0975abacf9064a0e7353/modules/kafka/src/main/java/org/testcontainers/containers/KafkaContainer.java#L76-L86

it set KAFKA_ADVERTISED_LISTENERS with BROKER:localhost:9092 explicitly. So Kafka SSL is not enabled when lauching the instance.

I think this is a bug in testcontainers.

@zhfeng
Copy link
Contributor

zhfeng commented Nov 1, 2021

It should be a simple workaround to override protected void configure() to set KAFKA_ADVERTISED_LISTENERS with SSL://localhost:9093,BROKER://localhost:9092. I've checked that it works on my local machine.

@zhfeng zhfeng self-assigned this Nov 1, 2021
zhfeng added a commit to zhfeng/camel-quarkus that referenced this issue Nov 2, 2021
zhfeng added a commit to zhfeng/camel-quarkus that referenced this issue Nov 2, 2021
zhfeng added a commit that referenced this issue Nov 2, 2021
* Revert "Temporarily disable kafka-sasl & kafka-ssl tests due to #3239"

This reverts commit 25a3d41.

* Fix #3239 to override KAFKA_ADVERTISED_LISTENERS env

* sync avro.version
jamesnetherton pushed a commit that referenced this issue Nov 3, 2021
* Revert "Temporarily disable kafka-sasl & kafka-ssl tests due to #3239"

This reverts commit 25a3d41.

* Fix #3239 to override KAFKA_ADVERTISED_LISTENERS env

* sync avro.version
@zhfeng
Copy link
Contributor

zhfeng commented Nov 5, 2021

This should be fixed in quarkus-main branch.

@zhfeng zhfeng closed this as completed Nov 5, 2021
@ppalaga
Copy link
Contributor

ppalaga commented Nov 5, 2021

I think we generally prefer marking issues as fixed only after they are merged in main. quarkus-main is an instable (is rebased regularly) branch and so the sha1 of the fix will change several times till it reaches main. I mean each fixed issue should contain a stable reference to the fix. This is important for both to be able to audit the fix at any time in the future and also to be able to port the fix to older branches.

@zhfeng
Copy link
Contributor

zhfeng commented Nov 5, 2021

OK, I get it. Let's reopen it.

@zhfeng zhfeng reopened this Nov 5, 2021
jamesnetherton pushed a commit that referenced this issue Nov 8, 2021
* Revert "Temporarily disable kafka-sasl & kafka-ssl tests due to #3239"

This reverts commit 25a3d41.

* Fix #3239 to override KAFKA_ADVERTISED_LISTENERS env

* sync avro.version
jamesnetherton pushed a commit that referenced this issue Nov 11, 2021
* Revert "Temporarily disable kafka-sasl & kafka-ssl tests due to #3239"

This reverts commit 25a3d41.

* Fix #3239 to override KAFKA_ADVERTISED_LISTENERS env

* sync avro.version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants