Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable Kafka ssl sasl tests #3252

Merged
merged 3 commits into from
Nov 2, 2021
Merged

Re-enable Kafka ssl sasl tests #3252

merged 3 commits into from
Nov 2, 2021

Conversation

zhfeng
Copy link
Contributor

@zhfeng zhfeng commented Nov 2, 2021

No description provided.

jamesnetherton
jamesnetherton reviewed Nov 2, 2021
View reviewed changes
...n-tests/kafka-sasl-ssl/src/test/java/org/apache/camel/quarkus/kafka/sasl/KafkaSaslSslIT.java

@DisabledOnNativeImage("https://github.com/apache/camel-quarkus/issues/3239")
@Disabled("https://github.com/apache/camel-quarkus/issues/2729")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a new issue, that one was closed and fixed some time ago.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I will raise a new issue to fix these native tests for KafkaSaslSslIT and KafkaSslTest.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and it should be fixed in main branch ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah you're right. It was already disabled on the main branch so I guess we should fix it there.

In that case we can probably merge this PR and take care of KafkaSaslSslIT on the main branch.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I raise #3254

@zhfeng zhfeng merged commit 16f53f2 into apache:quarkus-main Nov 2, 2021
jamesnetherton pushed a commit that referenced this pull request Nov 3, 2021
@zhfeng @jamesnetherton
Re-enable Kafka ssl sasl tests (#3252)
581ba8c 
* Revert "Temporarily disable kafka-sasl & kafka-ssl tests due to #3239"

This reverts commit 25a3d41.

* Fix #3239 to override KAFKA_ADVERTISED_LISTENERS env

* sync avro.version
jamesnetherton pushed a commit that referenced this pull request Nov 8, 2021
@zhfeng @jamesnetherton
Re-enable Kafka ssl sasl tests (#3252)
a546bd1 
* Revert "Temporarily disable kafka-sasl & kafka-ssl tests due to #3239"

This reverts commit 25a3d41.

* Fix #3239 to override KAFKA_ADVERTISED_LISTENERS env

* sync avro.version
jamesnetherton pushed a commit that referenced this pull request Nov 11, 2021
@zhfeng @jamesnetherton
Re-enable Kafka ssl sasl tests (#3252)
386f211 
* Revert "Temporarily disable kafka-sasl & kafka-ssl tests due to #3239"

This reverts commit 25a3d41.

* Fix #3239 to override KAFKA_ADVERTISED_LISTENERS env

* sync avro.version
jamesnetherton pushed a commit that referenced this pull request Nov 11, 2021
@zhfeng @jamesnetherton
Re-enable Kafka ssl sasl tests (#3252)
8d343bd 
* Revert "Temporarily disable kafka-sasl & kafka-ssl tests due to #3239"

This reverts commit 25a3d41.

* Fix #3239 to override KAFKA_ADVERTISED_LISTENERS env

* sync avro.version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesnetherton jamesnetherton jamesnetherton left review comments

@oscerd oscerd oscerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zhfeng @jamesnetherton @oscerd