Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate ServiceNow, Slack, Geocoder & Telegram tests to WireMock #1993

Merged
merged 7 commits into from Nov 4, 2020

Conversation

jamesnetherton
Copy link
Contributor

No description provided.

@@ -50,6 +50,7 @@ ExtensionSslNativeSupportBuildItem activateSslNativeSupport() {
items.add(new ReflectiveClassBuildItem(false, true, "com.google.maps.model.Bounds"));
items.add(new ReflectiveClassBuildItem(false, true, "com.google.maps.model.LatLng"));
items.add(new ReflectiveClassBuildItem(false, true, "com.google.maps.model.LocationType"));
items.add(new ReflectiveClassBuildItem(false, true, "com.google.maps.model.GeolocationPayload"));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your effort pays back!

Comment on lines -59 to -62
<dependency>
<groupId>org.apache.camel.quarkus</groupId>
<artifactId>camel-quarkus-integration-test-support-mock-backend</artifactId>
</dependency>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The auditing idea was based on the assumption that the number of camel-quarkus-integration-test-support-mock-backend occurrences in poms must be equal to the number of the magic log tokens. Now we are stopping to use camel-quarkus-integration-test-support-mock-backend .

Yes, camel-quarkus-integration-wiremock-support is a replacement, but probably not all mock will be HTTP, so the interested parties (cc @llowinge ) will have to add the number of camel-quarkus-integration-wiremock-support occurrences to the number of camel-quarkus-integration-test-support-mock-backend.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me think about this some more because there are probably other (better) ways of achieving this.

@jamesnetherton jamesnetherton merged commit 5302af6 into apache:master Nov 4, 2020
@jamesnetherton jamesnetherton deleted the stub-external-services branch November 4, 2020 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants