-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate ServiceNow, Slack, Geocoder & Telegram tests to WireMock #1993
Merged
jamesnetherton
merged 7 commits into
apache:master
from
jamesnetherton:stub-external-services
Nov 4, 2020
Merged
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
a4e9e24
Fix WireMock server field injection for native tests
jamesnetherton 6bda605
Discover WireMock mappings from the classpath to keep quarkus-platfor…
jamesnetherton 3445e6b
Stub ServiceNow tests with WireMock
jamesnetherton 58b1de8
Stub Slack tests with WireMock
jamesnetherton 3b0b66d
Stub Geocoder tests with WireMock
jamesnetherton 35070a4
Add missing geocoder reflective class
jamesnetherton 759bc34
Stub Telegram tests with WireMock
jamesnetherton File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
110 changes: 0 additions & 110 deletions
110
...telegram/src/main/java/org/apache/camel/quarkus/component/telegram/it/TelegramRoutes.java
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 changes: 0 additions & 24 deletions
24
integration-tests/telegram/src/main/resources/mock-messages/editMessageLiveLocation.json
This file was deleted.
Oops, something went wrong.
41 changes: 0 additions & 41 deletions
41
integration-tests/telegram/src/main/resources/mock-messages/getUpdates.json
This file was deleted.
Oops, something went wrong.
25 changes: 0 additions & 25 deletions
25
integration-tests/telegram/src/main/resources/mock-messages/sendAudio.json
This file was deleted.
Oops, something went wrong.
24 changes: 0 additions & 24 deletions
24
integration-tests/telegram/src/main/resources/mock-messages/sendDocument.json
This file was deleted.
Oops, something went wrong.
23 changes: 0 additions & 23 deletions
23
integration-tests/telegram/src/main/resources/mock-messages/sendLocation.json
This file was deleted.
Oops, something went wrong.
20 changes: 0 additions & 20 deletions
20
integration-tests/telegram/src/main/resources/mock-messages/sendMessage.json
This file was deleted.
Oops, something went wrong.
27 changes: 0 additions & 27 deletions
27
integration-tests/telegram/src/main/resources/mock-messages/sendPhoto.json
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The auditing idea was based on the assumption that the number of camel-quarkus-integration-test-support-mock-backend occurrences in poms must be equal to the number of the magic log tokens. Now we are stopping to use camel-quarkus-integration-test-support-mock-backend .
Yes, camel-quarkus-integration-wiremock-support is a replacement, but probably not all mock will be HTTP, so the interested parties (cc @llowinge ) will have to add the number of camel-quarkus-integration-wiremock-support occurrences to the number of camel-quarkus-integration-test-support-mock-backend.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me think about this some more because there are probably other (better) ways of achieving this.