Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only invoke completed method on unknown arguments if the failure remedy is FAIL #2373

Merged
merged 1 commit into from Mar 25, 2021

Conversation

jamesnetherton
Copy link
Contributor

No description provided.

@jamesnetherton jamesnetherton marked this pull request as draft March 25, 2021 05:28
@jamesnetherton
Copy link
Contributor Author

Converted to draft as there's something I need to check before merging.

@jamesnetherton
Copy link
Contributor Author

@ppalaga Do you mind taking a second look at this. I made some tweaks:

  • I realised that if on-failure is warn, then you need to process all valid arguments, instead of stopping on the first invalid argument, so I fixed that.

  • To make the warning message output a bit friendlier, I thought it'd be best to truncate long arguments (E.g like a classpath) and abbreviate with '...'.

@jamesnetherton jamesnetherton marked this pull request as ready for review March 25, 2021 06:34
@jamesnetherton
Copy link
Contributor Author

The test failure is not related - hence merging this.

@jamesnetherton jamesnetherton merged commit 0a9e60f into apache:master Mar 25, 2021
@jamesnetherton jamesnetherton deleted the fix-main-arg-parsing-2 branch March 25, 2021 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants