-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not use deprecated BuildStep.applicationArchiveMarkers() #2574
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…3.10 breaks Quarkiverse Minio and MinioClientProducer in our test
… to run Avro tests
zbendhiba
approved these changes
May 11, 2021
thanks @aloubyansky |
@aloubyansky the AWS tests are now failing :D |
It looks like the examples-tests is not properly configured
|
aloubyansky
force-pushed
the
archive-markers
branch
from
May 11, 2021 15:38
f9a2d55
to
6bdb7d8
Compare
There was a cyclic build step dependency. |
zbendhiba
force-pushed
the
camel-main
branch
3 times, most recently
from
May 11, 2021 23:58
478f3c5
to
57ff9f6
Compare
Thanks @aloubyansky. I applied this change to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BuildStep.applicationArchiveMarkers()
was deprecated quite a long time ago and now has been removed from the upcoming Quarkus 2.0.0.Alpha3 (quarkusio/quarkus#17018)This PR replaces the use of the removed API with the one that should be used instead, i.e. producing instances of
io.quarkus.deployment.builditem.AdditionalApplicationArchiveMarkerBuildItem
directly.