Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use deprecated BuildStep.applicationArchiveMarkers() #2574

Closed
wants to merge 21 commits into from

Conversation

aloubyansky
Copy link
Contributor

BuildStep.applicationArchiveMarkers() was deprecated quite a long time ago and now has been removed from the upcoming Quarkus 2.0.0.Alpha3 (quarkusio/quarkus#17018)
This PR replaces the use of the removed API with the one that should be used instead, i.e. producing instances of io.quarkus.deployment.builditem.AdditionalApplicationArchiveMarkerBuildItem directly.

@zbendhiba
Copy link
Contributor

thanks @aloubyansky

@zbendhiba
Copy link
Contributor

@aloubyansky the AWS tests are now failing :D

@aloubyansky
Copy link
Contributor Author

It looks like the examples-tests is not properly configured

Caused by: org.apache.maven.plugin.PluginContainerException: An API incompatibility was encountered while executing io.quarkus:quarkus-maven-plugin:1.13.0.Final:build: java.lang.NoSuchMethodError: 'boolean io.quarkus.bootstrap.app.QuarkusBootstrap.isAuxiliaryApplication()'

@aloubyansky
Copy link
Contributor Author

There was a cyclic build step dependency.

@zbendhiba zbendhiba force-pushed the camel-main branch 3 times, most recently from 478f3c5 to 57ff9f6 Compare May 11, 2021 23:58
@jamesnetherton
Copy link
Contributor

Thanks @aloubyansky. I applied this change to the main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants