Add soap dataformat quarkus extension #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Mar 12, 2020
ppalaga
reviewed
Mar 12, 2020
integration-tests/soap/pom.xml
Outdated
Comment on lines
114
to
118
| <configuration> | ||
| <systemProperties> | ||
| <native.image.path>${project.build.directory}/${project.build.finalName}-runner</native.image.path> | ||
| </systemProperties> | ||
| </configuration> |
There was a problem hiding this comment.
Suggested change
| <configuration> | |
| <systemProperties> | |
| <native.image.path>${project.build.directory}/${project.build.finalName}-runner</native.image.path> | |
| </systemProperties> | |
| </configuration> |
The config can be removed.
| ## WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| ## See the License for the specific language governing permissions and | ||
| ## limitations under the License. | ||
| ## --------------------------------------------------------------------------- |
There was a problem hiding this comment.
Empty application.properties can be removed.
| assertThat(resp).contains("<name>" + msg + "</name>"); | ||
| assertThat(resp).contains("<ns2:Envelope xmlns:ns2=\"http://schemas.xmlsoap.org/soap/envelope/\""); | ||
|
|
||
| System.out.println(resp); |
There was a problem hiding this comment.
Could you please remove the System.out.println ?
There was a problem hiding this comment.
The last issue from my PoV.
...ration-tests/soap/src/main/java/org/apache/camel/quarkus/component/soap/it/SoapResource.java
Show resolved
Hide resolved
...ration-tests/soap/src/main/java/org/apache/camel/quarkus/component/soap/it/SoapResource.java
Show resolved
Hide resolved
extensions/soap/runtime/pom.xml
Outdated
|
|
||
| <properties> | ||
| <firstVersion>1.0.0-M5</firstVersion> | ||
| <saaj.version>1.5.0</saaj.version> |
There was a problem hiding this comment.
Is the saaj.version version property used anywhere?
There was a problem hiding this comment.
I forgot to remove this. Thanks!
mmelko
force-pushed
the
camel-quarkus-soap
branch
from
a0bc750
to
1bfe870
Compare
mmelko
force-pushed
the
camel-quarkus-soap
branch
from
1bfe870
to
0db4448
Compare
<dependency>
<groupId>javax.xml.ws</groupId>
<artifactId>jaxws-api</artifactId>
</dependency>Had to be added to work this with java 11. Now I'm waiting for CI results |
jamesnetherton
approved these changes
Mar 13, 2020
ppalaga
approved these changes
Mar 13, 2020
|
Thanks, @mmelko ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #763