Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document update #164

Closed
wants to merge 6 commits into from
Closed

Document update #164

wants to merge 6 commits into from

Conversation

NiteshKoushik
Copy link
Contributor

Grammatical correction

@NiteshKoushik
Document update
8b8b7fa 
Grammatical correction
@NiteshKoushik
Document Update
02b64cf 
Grammatical correction
oscerd
oscerd requested changes Sep 14, 2020
View reviewed changes
Copy link
Contributor

@oscerd oscerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are autogenerated from source code javadoc, you need to modify the javadoc

@NiteshKoushik
Document Update
a5900e9 
Removal of duplicate words and Grammatical correction
@NiteshKoushik
Document Update
69d652f 
Spelling correction from "ore" to "or" and grammatical correction
@NiteshKoushik
Document Update
626ecd1 
Grammatical correction
@NiteshKoushik
Copy link
Contributor Author

How to go to the Javadoc of each file. Is there a way to navigate to its base link.

@oscerd
Copy link
Contributor

oscerd commented Sep 14, 2020

Grep the phrase

@oscerd
Copy link
Contributor

oscerd commented Sep 14, 2020

And clone the project locally

@NiteshKoushik
Copy link
Contributor Author

Can you please share the javadoc link, tried checking the files. Since there are many files difficult to find the actual file which is pointing to it.

@NiteshKoushik
Copy link
Contributor Author

Is it possible to share the Javadoc link.

@oscerd
Copy link
Contributor

oscerd commented Sep 16, 2020

https://github.com/apache/camel-spring-boot/blob/master/core/camel-spring-boot/src/main/java/org/apache/camel/spring/boot/CamelConfigurationProperties.java

@NiteshKoushik
Document update
a48d7c9 
Changes from "a ANT" to "an ANT"
@NiteshKoushik
Copy link
Contributor Author

Hello @oscerd, Thanks for sharing the javadoc link. I have done the changes in the javadoc link. But the changes are partial, I was not able to do complete changes in the given link, when compare to the changes which are present here. Also I feel partial code is getting generated from Javadoc and other piece of code is getting referred directly.

@oscerd
Copy link
Contributor

oscerd commented Sep 16, 2020

Thanks, you could split in two different PRs and close this one

@NiteshKoushik
Copy link
Contributor Author

Ok. Thanks

cunningt added a commit to cunningt/camel-spring-boot that referenced this pull request Feb 22, 2023
@cunningt @zhfeng
Update to use camel.lra.enabled (apache#752) (apache#164)
812a359 
* Update to use camel.lra.enabled (apache#752)

* Add additional entries so that sap component / bom do not get excluded by plugin

---------

Co-authored-by: Zheng Feng <zh.feng@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscerd oscerd oscerd requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NiteshKoushik @oscerd