Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed issue for content wider than screen for pages #200

Merged
merged 5 commits into from
Mar 30, 2020

Conversation

jyotiattri
Copy link
Contributor

This adds a fix for Content wider than screen (16 pages) from Mobile usability issues reported in Google search console

cc : @zregvart

Copy link
Member

@zregvart zregvart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preview is here.

This seems to increase the font size for code blocks, for example in ActiveMQ component on desktop.

I'm not sure why we need three additional media selectors when the rules don't change within those selectors, seems redundant.

I think it's best that we keep the existing media selectors and not introduce additional ones.

@jyotiattri
Copy link
Contributor Author

Ok, I got it. I can change it.

Copy link
Member

@zregvart zregvart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far we have media breakpoints on:

  • > 1024px
  • > 480px && < 1023px
  • > 769px
  • < 626px
  • < 1023px

I think here we need to go with one of existing breakpoints. Adding a new one increases the overall complexity and testing exponentially.

antora-ui-camel/src/css/doc.css Outdated Show resolved Hide resolved
@zregvart
Copy link
Member

I'm not sure about using vh font-size unit inconsistently, at 626px this leads to quite a big difference between font sizes:

Screenshot_2020-03-15 ActiveMQ Component - Apache Camel

I think it's best that we focus on overflow-wrap and overflow changes here and on changing font-sizes in a separate issue/pull request.

@jyotiattri
Copy link
Contributor Author

Requested Changes are done in this PR.

@jyotiattri
Copy link
Contributor Author

Hi, @zregvart
Please let me know is there something to do in this PR.

Copy link
Member

@zregvart zregvart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very complex way of doing this. I think we need something much simpler.

antora-ui-camel/src/css/base.css Outdated Show resolved Hide resolved
antora-ui-camel/src/css/doc.css Outdated Show resolved Hide resolved
antora-ui-camel/src/css/release.css Outdated Show resolved Hide resolved
@zregvart zregvart force-pushed the issue/content-wider-than-screen branch 2 times, most recently from f113bda to 584c26a Compare March 26, 2020 09:48
@zregvart
Copy link
Member

I've rebased this on current master branch, I'm interested to see if there are any issues with this with other changes that have happened in the meantime. So let's wait for the new preview.

@jyotiattri
Copy link
Contributor Author

@zregvart, Ok Thanks

@zregvart
Copy link
Member

Preview is here.

Copy link
Member

@zregvart zregvart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zregvart zregvart force-pushed the issue/content-wider-than-screen branch from 584c26a to eb681e8 Compare March 30, 2020 12:47
@zregvart zregvart merged commit 0bfae0a into apache:master Mar 30, 2020
@zregvart
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants