-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed issue for content wider than screen for pages #200
fixed issue for content wider than screen for pages #200
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preview is here.
This seems to increase the font size for code blocks, for example in ActiveMQ component on desktop.
I'm not sure why we need three additional media selectors when the rules don't change within those selectors, seems redundant.
I think it's best that we keep the existing media selectors and not introduce additional ones.
Ok, I got it. I can change it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So far we have media breakpoints on:
> 1024px
> 480px && < 1023px
> 769px
< 626px
< 1023px
I think here we need to go with one of existing breakpoints. Adding a new one increases the overall complexity and testing exponentially.
Requested Changes are done in this PR. |
Hi, @zregvart |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very complex way of doing this. I think we need something much simpler.
f113bda
to
584c26a
Compare
I've rebased this on current master branch, I'm interested to see if there are any issues with this with other changes that have happened in the meantime. So let's wait for the new preview. |
@zregvart, Ok Thanks |
Preview is here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
584c26a
to
eb681e8
Compare
Thanks! |
This adds a fix for Content wider than screen (16 pages) from Mobile usability issues reported in Google search console
cc : @zregvart