Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAMEL-10409: Prevent double release of request #1268

Closed
wants to merge 3 commits into from

Conversation

tivv
Copy link

@tivv tivv commented Nov 14, 2016

Please also merge into 2.18 as it's quite important problem that may lead to buffer corruption (buffer is being incorrectly reused)

Vitalii Tymchyshyn added 2 commits November 13, 2016 23:51
Double release of netty buffer
Double release of netty buffer
@WillemJiang
Copy link
Member

Hi Vitalii,
The patch looks good.
Do you mind create an unit test to reproduce the issue?
We can use it for regression test.

@WillemJiang
Copy link
Member

I tried to use the test case in the JIRA CAMEL-10409 to verify the fix, but it hard to write an unit test as the warning message just show from the log. So I just apply the patch into the master branch.

Double release of netty buffer: Addedtest
@tivv
Copy link
Author

tivv commented Nov 15, 2016

Added a test

@oscerd
Copy link
Contributor

oscerd commented Nov 16, 2016

@tivv the PR has been merged by @WillemJiang

Can you close the PR?

Thanks.

@davsclaus
Copy link
Contributor

Thanks for the PR it has been merged. Do you mind closing this?

@tivv tivv closed this Nov 16, 2016
zregvart pushed a commit to zregvart/camel that referenced this pull request Jul 9, 2021
ENTESB-12624 - Upgrade to AMQ Streams 1.4.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants