CAMEL-10763 Make HTTP4 component easy to extend #1426
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, can you please add the JIRA references in the commit messages? Thanks! |
This commit extracts creation of `HttpClientConnectionManager` in a separate method `createConnectionManager`, this method can be then reused from a component based on the `HttpComponent`. Also this commit extracts creation of `HttpClientBuilder` in a separate method `createHttpClientBuilder`, this method can be then reused from a component based on the `HttpComponent`.
|
Thank you for reviewing @oscerd, I've squashed the two commits and modified the commit subject to contain the JIRA issue. |
|
Oh already merged, I tend to be not so slow ;) |
|
Thanks for the PR it has been merged. Do you mind closing this? |
|
Thanks @oscerd, @davsclaus 👍 |
|
@davsclaus is too fast for me :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've re-factored the creation of
HttpClientBuilderandHttpClientConnectionManagerinto separate methods. This makescreateEndpointcontain less logic so that the component that could be based oncamel-httpcould use these new metod to create it's ownEndpointimplementation.