Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAMEL-10803 Base undertow component on http-common #1450

Closed
wants to merge 2 commits into from

Conversation

zregvart
Copy link
Member

@zregvart zregvart commented Feb 7, 2017

Please don't merge

I would like some feedback on this first. Still to do:

  • Make UndertowComponent and UndertowEndpoint extend HttpCommonComponent and HttpCommonEndpoint
  • Implement support for options from http-common component
    • chunked
    • disableStreamCache
    • proxyHost
    • proxyPort
    • authMethodPriority
    • connectionClose
    • traceEnabled
    • responseBufferSize
    • ignoreResponseBody
    • copyHeaders
    • eagerCheckContentAvailable
    • mapHttpMessageBody
    • mapHttpMessageHeaders
    • mapHttpMessageFormUrlEncodedBody
    • okStatusCodeRange
    • urlRewrite
    • async (though Undertow is heavily async, so may be ignored)

@UriParam(label = "security")
private SSLContextParameters sslContextParameters;
@UriParam(label = "consumer")
Copy link
Contributor

@apupier apupier Feb 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are all the removed parameters part of HttpCommonEndpoint?
If not, it implies API break, so would need to keep them, remapping to correct value if possible and set as deprecated

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They should be, if I haven't missed any :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think 98% of them are inspired/copied from http and thus have the same name. It may be that http-common may have more options which undertow did not have, so you get more now.

@davsclaus
Copy link
Contributor

Zoran, how is it going ?

@zregvart
Copy link
Member Author

@davsclaus sorry I'm caught up with other work, should I close this PR and work off a branch until I get more done?

@davsclaus
Copy link
Contributor

Ah its fine - whatever is the easiest for you.

When we get closer to 2.19 release we would need to know more if it can make it or not

@zregvart zregvart force-pushed the CAMEL-10803 branch 4 times, most recently from 0d610f1 to ab30501 Compare February 23, 2017 10:51
@zregvart zregvart force-pushed the CAMEL-10803 branch 2 times, most recently from bc6f106 to 12a394f Compare March 6, 2017 11:17
@zregvart zregvart force-pushed the CAMEL-10803 branch 2 times, most recently from 431e177 to d5bcddd Compare March 22, 2017 20:28
Initial commit that just replaces the base class for `UndertowComponent`
and `UndertowEndpoint`, removes the duplicate properties and updates
method names where needed.
Adds support for chunked transfer encoding in UndertowConsumer via the
`chunked` endpoint option.
@zregvart zregvart closed this May 11, 2018
zregvart pushed a commit to zregvart/camel that referenced this pull request Jan 13, 2021
[ENTESB-14199]search camel-openapi-java first from the classpath and …
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants