-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CAMEL-10803 Base undertow component on http-common #1450
Conversation
@UriParam(label = "security") | ||
private SSLContextParameters sslContextParameters; | ||
@UriParam(label = "consumer") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are all the removed parameters part of HttpCommonEndpoint?
If not, it implies API break, so would need to keep them, remapping to correct value if possible and set as deprecated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They should be, if I haven't missed any :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I think 98% of them are inspired/copied from http and thus have the same name. It may be that http-common may have more options which undertow did not have, so you get more now.
Zoran, how is it going ? |
@davsclaus sorry I'm caught up with other work, should I close this PR and work off a branch until I get more done? |
Ah its fine - whatever is the easiest for you. When we get closer to 2.19 release we would need to know more if it can make it or not |
0d610f1
to
ab30501
Compare
bc6f106
to
12a394f
Compare
431e177
to
d5bcddd
Compare
Initial commit that just replaces the base class for `UndertowComponent` and `UndertowEndpoint`, removes the duplicate properties and updates method names where needed.
Adds support for chunked transfer encoding in UndertowConsumer via the `chunked` endpoint option.
[ENTESB-14199]search camel-openapi-java first from the classpath and …
Please don't merge
I would like some feedback on this first. Still to do:
UndertowComponent
andUndertowEndpoint
extendHttpCommonComponent
andHttpCommonEndpoint
http-common
componentchunked
disableStreamCache
proxyHost
proxyPort
authMethodPriority
connectionClose
traceEnabled
responseBufferSize
ignoreResponseBody
copyHeaders
eagerCheckContentAvailable
mapHttpMessageBody
mapHttpMessageHeaders
mapHttpMessageFormUrlEncodedBody
okStatusCodeRange
urlRewrite
async
(though Undertow is heavily async, so may be ignored)