Added interceptorClasses property to Kafka #1456
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @lmlynik thanks for the PR :-) I will review and merge soon :-) |
oscerd
reviewed
Feb 10, 2017
|
|
||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
What's this file, we have an auto-generated file in src/main/docs called kafka-component.adoc, all the manual changes to documentation must be there. Can you remove this?
davsclaus
reviewed
Feb 10, 2017
| @@ -62,6 +62,10 @@ | |||
| @UriParam | |||
| private String clientId; | |||
|
|
|||
| //interceptor.classes | |||
| @UriParam | |||
There was a problem hiding this comment.
Can you add label = "monitoring" as its kinda intended for this kind of things, isnt it?
near-ethic
reviewed
Feb 10, 2017
| @@ -102,11 +102,13 @@ public void testAllProducerConfigProperty() throws Exception { | |||
| assertEquals("test", endpoint.getConfiguration().getSslEndpointAlgorithm()); | |||
| assertEquals("SunX509", endpoint.getConfiguration().getSslKeymanagerAlgorithm()); | |||
| assertEquals("PKIX", endpoint.getConfiguration().getSslTrustmanagerAlgorithm()); | |||
| assertEquals("PKIX", endpoint.getConfiguration().getSslTrustmanagerAlgorithm()); | |||
There was a problem hiding this comment.
Could you remove this duplicate line?
lmlynik
commented
Feb 10, 2017
| import org.apache.kafka.clients.consumer.OffsetAndMetadata; | ||
| import org.apache.kafka.common.TopicPartition; | ||
|
|
||
| public class MockConsumerInterceptor implements ConsumerInterceptor<String, String> { |
There was a problem hiding this comment.
In general I don't like this idea, is there something in the current Camel repo which can help mocking such functionality like list backed interceptors?
|
Thanks for the PR it has been merged. Do you mind closing this? |
zregvart
pushed a commit
to zregvart/camel
that referenced
this pull request
Jan 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some monitoring tools require to provide the interceptor classes to work