Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAMEL-11242 Split camel-twitter component/endpoint into 4 (directmess… #1712

Closed
wants to merge 2 commits into from

Conversation

igarashitm
Copy link
Contributor

…age, search, streaming, timeline)

@davsclaus
Copy link
Contributor

We should maybe consider twitter-search:endpointId, to let endpointId be the keywords, so you can do a search using twitter-search:#apachecamel to search for #apachecamel etc.

And there is another one of them that has an unused path param. Maybe we can turn that into something useful?

@davsclaus
Copy link
Contributor

But maybe we should do that in another PR so this big PR is just the migration as-is, and then a separate PRs for more refinements.

@davsclaus
Copy link
Contributor

Just to be sure, you updated the twitter examples as well we have in the examples directory?

@igarashitm
Copy link
Contributor Author

Good point! I thought about using search keyword for URI path, but I focused on refactoring this time. The direct message also has a dummy URI path, which could be a destination user ID for producer, but still wondering if there's something good for consumer. Anyway I'll raise a follow up JIRA and submit another PR.
And yes, I updated a few examples which are using twitter endpoint to use new URI.

@asfgit asfgit closed this in eee8fda May 24, 2017
asfgit pushed a commit that referenced this pull request May 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants