CAMEL-11927 - Improve support for soap header transformations - [Than… #2055
Conversation
…ks for the PR - Richard Groote(helping to raise a github PR by onders)]
|
Thanx, for creating the pull request |
|
@richardgroote , however I am not sure if this is needed OOTB. Because spring-ws component already allows to have custom filter and bind via |
|
Yes, it's possible to define your own message filter. But it would be nice if Apache Camel would support the functionality to transform the soap header before sending the soap message OOTB. I've seen a lot of use cases by our customers where only adding the headers was not enough. The solution for our customers was to use the header transformation filter which i supplied in the issue and i thought it might be useful for other users of Apache Camel |
|
This was just my first sight. If the community sees the value, it will be good to go. Thanks for the contribution. Keep up the good work |
|
You need to update the documentation as well. Also I suggest to add javadoc to that filter class where you say that its using XSLT only, which otherwise can take people by surprise. eg to do some transformation using simpler ways. |
|
@richardgroote , do you mind adding javadoc so that we can update PR and have it merged? |
|
See issue for the javadoc |
|
@richardgroote , thanks. I have not yet found a time slot to reflect your changes. I will try to look and update and possibly merge your changes at the soonest I can. (sorry i am extremely busy with other stuff at the moment.) thanks |
|
@richardgroote reflected your changes. @davsclaus wdyt? |
|
Yeah this looks fine, thanks |
…ks for the PR - Richard Groote(helping to raise a github PR by onders)]