Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAMEL-13643: Change Spring Boot starters groupId #3334

Merged
merged 1 commit into from Nov 15, 2019

Conversation

zregvart
Copy link
Member

This changes the Spring Boot starters Maven groupId from org.apache.camel to org.apache.camel.springboot. Also updates the documentation, BOM generation, archetype and examples.

@zregvart
Copy link
Member Author

Link to the running build

@davsclaus
Copy link
Contributor

Yeah its a bigger change when there are some many starters that need to be changed.

@zregvart
Copy link
Member Author

hmm, I'm getting an error from Maven:

[ERROR] Failed to execute goal on project camel-spring-boot-starter: Could not resolve dependencies for project org.apache.camel.springboot:camel-spring-boot-starter:jar:3.0.0-SNAPSHOT: Could not find artifact org.apache.camel.springboot:camel-core-starter:jar:3.0.0-SNAPSHOT in Nexus (http://repository.apache.org/snapshots) -> [Help 1]

I tested locally with rm -rf ~/.m2/repository/org/apache/camel && ./mvnw -o -DskipTests -DskipITs -Psourcecheck clean install.

I need to investigate this a bit.

@zregvart
Copy link
Member Author

Oddly enough this requires a maven-checkstyle-plugin upgrade. I think it's the resolution of dependencies triggered by maven-checkstyle-plugin that is causing this issue (that's why I created CAMEL-14180)

Copy link
Contributor

@oscerd oscerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to resolve the conflicts

@zregvart
Copy link
Member Author

I need to rebase this, but it also depends on #3341 getting merged first, otherwise it will fail the first time it runs on CI.

This changes the Spring Boot starters Maven groupId from
`org.apache.camel` to `org.apache.camel.springboot`. Also updates the
documentation, BOM generation, archetype and examples.
@zregvart
Copy link
Member Author

Rebased on current master, a link to the new CI build.

@zregvart zregvart merged commit 9f0b866 into master Nov 15, 2019
@zregvart zregvart deleted the pr/spring-boot-groupid branch November 15, 2019 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants