Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAMEL-16127: Revisit PackageScanResourceResolver #4991

Merged
merged 1 commit into from Feb 2, 2021

Conversation

lburgazzoli
Copy link
Contributor

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • If you're unsure, you can format the pull request title like [CAMEL-XXX] Fixes bug in camel-file component, where you replace CAMEL-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Psourcecheck in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
    Below are the contribution guidelines:
    https://github.com/apache/camel/blob/master/CONTRIBUTING.md

Copy link
Contributor

@davsclaus davsclaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is maybe a few checkstyle issues.
Also I wonder if the old APIs should be marked as deprecated. The new with the Resource is a better api.

@lburgazzoli
Copy link
Contributor Author

There is maybe a few checkstyle issues.
Also I wonder if the old APIs should be marked as deprecated. The new with the Resource is a better api.

done

@lburgazzoli lburgazzoli force-pushed the CAMEL-16127 branch 3 times, most recently from 3f1c4ff to e80995f Compare February 2, 2021 06:23
@lburgazzoli lburgazzoli force-pushed the CAMEL-16127 branch 3 times, most recently from 9f124f7 to 3b4fb1f Compare February 2, 2021 06:39
@lburgazzoli lburgazzoli merged commit 82c6cb1 into apache:master Feb 2, 2021
@lburgazzoli lburgazzoli deleted the CAMEL-16127 branch February 2, 2021 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants