Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed clearing of field 'Name' to allow upserts with custom external I... #57

Closed
wants to merge 1 commit into from
Closed

Removed clearing of field 'Name' to allow upserts with custom external I... #57

wants to merge 1 commit into from

Conversation

mdarcemont
Copy link

Hi,

The component "camel-salesforce" doesn't allow upserts with a custom external ID.

We have a data model with a new field 'ExternalID__c' which is the external ID, and where 'Name' is a simple mandatory field.
So when we want to insert a new object with an upsert operation on field "ExternalID__c", the field 'Name' is cleared, causing a Salesforce error :

...
.to("salesforce:upsertSObject?sObjectName=Account&sObjectIdName=ExternalID__c");

=>

[{"errorCode":"REQUIRED_FIELD_MISSING","message":"Required fields are missing: [Name]","fields":["Name"]}], statusCode: 400}]

Moreover, we also want to update the field 'Name', which is currently not possible.

I suggest you to remove the clearing of field 'Name' during the upsert.

Thanks.

Manuel

@dhirajsb
Copy link
Member

Hi Manuel, it does look like a valid use case. The patch needs other changes for integration tests for the component. I have created a Camel JIRA https://issues.apache.org/jira/browse/CAMEL-7021 for this issue. I will add a patch that includes your change and updated tests.

Thanks,
Dhiraj.

@davsclaus
Copy link
Contributor

CAMEL-7021 has been fixed. Do you mind closing this PR?

@mdarcemont mdarcemont closed this Feb 5, 2014
onderson pushed a commit to onderson/camel that referenced this pull request Aug 25, 2017
@realmfoo @onderson
# This is a combination of 103 commits.
dd370d3 
# The first commit's message is:

Unable to change DataFormat.contentTypeHeader value to false

JaxbDataFormat has a contentTypeHeader property with default value of TRUE. It should be able to change contentTypeHeader to FALSE.

# This is the commit message #2:

Improve SupervisingRouteController

# This is the commit message #3:

Refactor BackOff timer

# This is the commit message apache#4:

Upgrade Jgroups to version 4.0.5.Final

# This is the commit message apache#5:

CAMEL-11657 - Camel-spring-security: The Karaf feature need spring-security-config to be installed

# This is the commit message apache#6:

Upgrade Hazelcast to version 3.8.4

# This is the commit message apache#7:

Changed S3Producer to use S3Constants.S3_OPERATION instead of EC2Constants.OPERATION
# This is the commit message apache#8:

Import of the IEC 60870 component

This change adds an IEC 60870 camel component based on the
IEC 60870 implementation of Eclipse NeoSCADA.

Signed-off-by: Jens Reimann <jreimann@redhat.com>

# This is the commit message apache#9:

Amend changes based on review.

Signed-off-by: Jens Reimann <jreimann@redhat.com>

# This is the commit message apache#10:

Add the camel-iec60870 and camel-iec60870-starter

This change adds the ne camel-iec6087 and camel-iec60870-starter
modules to a few build files.

Signed-off-by: Jens Reimann <jreimann@redhat.com>

# This is the commit message apache#11:

Regen

# This is the commit message apache#12:

Added camel-iec60870 to components POM

# This is the commit message apache#13:

Fix CS

# This is the commit message apache#14:

CAMEL-11659: Create a ClusteredRouteController

# This is the commit message apache#15:

ClusteredRouteController: use spring-boot to spin up the boostrap node

# This is the commit message apache#16:

fix using MasterComponent

# This is the commit message apache#17:

closing entity manager

# This is the commit message apache#18:

surrounded with try/catch/finally to ensure entity manager always closes

# This is the commit message apache#19:

CAMEL-11630: Fixed CS. This closes apache#1883.

# This is the commit message apache#20:

camel-bigquery: add initial version to endpoint annotations

# This is the commit message apache#21:

camel-bigquery: fix endpoint annotation

# This is the commit message apache#22:

Fixes Checkstyle issues in Salesforce component

# This is the commit message apache#23:

Code style: remove unused imports

# This is the commit message apache#24:

CAMEL-11668: CompositeApiClient class in the camel-salesforces component cannot close a null InputStream

# This is the commit message apache#25:

CAMEL-11561: Cleanup Salesforce integration tes...

...ts setup

This removes unused profiles that might conflict when running the
Ant Migration Tool and defines Connectec App OAuth Client Id and Client
Secret from the `test-salesforce-login.properties`. So it is up to the
user of the tests to pick a unique Client Id, i.e. simply by creating an
Connected App and using those values and then deleting it.

# This is the commit message apache#26:

CAMEL-11668: CompositeApiClient class in the ca...

...mel-salesforces component cannot close a null InputStream

Cleaned up to use `IOHelper.close` instead.

# This is the commit message apache#27:

CAMEL-11629: Cleanup SalesforceComponentVerifie...

...rTest

Splits the SalesforceComponentVerifier test into integration
(connectivity) and unit test (parameter). The integration test now
relies on `LoginConfigHelper` that reads its configuration from
`salesforce-test-login.properties`.

# This is the commit message apache#28:

Regen

# This is the commit message apache#29:

Polished summary of new component.

# This is the commit message apache#30:

Fix typo on rest endpoints

# This is the commit message apache#31:

CAMEL-11438 added javadoc to the endpoint class

+ test class polished
# This is the commit message apache#32:

regenerate camel-crypto-cms-starter

# This is the commit message apache#33:

CAMEL-11638: upgrade camel-ssh to use apache-sshd version 1.6.0

# This is the commit message apache#34:

CAMEL-11638: upgrade camel-jsch to use apache-sshd version 1.6.0

# This is the commit message apache#35:

CAMEL-11638: upgrade camel-ftp to use apache-sshd version 1.6.0

# This is the commit message apache#36:

regenerate

# This is the commit message apache#37:

add camel-google-bigquery-starter to kit

# This is the commit message apache#38:

Upgrade hbase. This fixes apache#1896

# This is the commit message apache#39:

CAMEL-11621: extend simple date formatter for properties
# This is the commit message apache#40:

Polished. This fixes apache#1890

# This is the commit message apache#41:

[CAMEL-11688]ensure transport endpoint configuration will be take into account when create JettyRestHttpBinding from REST DSL

# This is the commit message apache#42:

Upgrade Caffeine to version 2.5.5

# This is the commit message apache#43:

Upgrade Chronicle Core to version 1.9.3

# This is the commit message apache#44:

Upgrade Chronicle Threads to version 1.8.2

# This is the commit message apache#45:

Upgrade Chronicle Bytes to version 1.9.6

# This is the commit message apache#46:

Upgrade Chornicle Network to version 1.9.2

# This is the commit message apache#47:

Upgrade Chronicle Wire to version 1.9.10

# This is the commit message apache#48:

CAMEL-11671 dont rebuild the request and respect url encoding of the original request

# This is the commit message apache#49:

Upgrade Spring Cloud Netflix to version 1.3.4.RELEASE

# This is the commit message apache#50:

CAMEL-11674 - Couchbase client is never shut down

# This is the commit message apache#51:

CAMEL-11316: Added support for HTTP OPTIONS in camel-restlet

# This is the commit message apache#52:

Fixed CS

# This is the commit message apache#53:

Upgrade Mybatis to version 3.4.5

# This is the commit message apache#54:

CAMEL-11685 - Camel-Hazelcast: Add removeAll and removeIf to queue component

# This is the commit message apache#55:

CAMEL-11685 - Fixed docs

# This is the commit message apache#56:

Revert "CAMEL-11655 - Camel-Nagios: Use Encryption enum instead of EncryptionMethod"

This reverts commit efee1f7.

# This is the commit message apache#57:

CAMEL-11665 - Camel-Nagios: Deprecate EncryptionMethod and use Encryption Enum

# This is the commit message apache#58:

CAMEL-11611 - Add a knownHosts option to the camel-ssh component

# This is the commit message apache#59:

CAMEL-11611 - Adjusted the code to reflect the use of Apache Sshd 1.6.0

# This is the commit message apache#60:

CAMEL-11682: Add sasl.jaas.config setting

# This is the commit message apache#61:

CAMEL-11682 - Regen and docs

# This is the commit message apache#62:

CAMEL-11438 documentation improved
# This is the commit message apache#63:

CAMEL-11611: polish

# This is the commit message apache#64:

Regen

# This is the commit message apache#65:

Upgrade Chronicle Bytes to version 1.9.7

# This is the commit message apache#66:

Upgrade Chronicle Core to version 1.9.4

# This is the commit message apache#67:

Upgrade Chronicle Network to version 1.9.3

# This is the commit message apache#68:

Upgrade Chronicle Wire to version 1.9.11

# This is the commit message apache#69:

Upgrade RxJava to version 2.1.3

# This is the commit message apache#70:

CAMEL-11694 - Camel-Hazelcast: Add more operation to queue - Take operation

# This is the commit message apache#71:

CAMEL-11694 - Camel-Hazelcast: Add more operation to queue - Retain All operation

# This is the commit message apache#72:

CAMEL-11694 - Camel-Hazelcast: Add more operation to queue - Docs updated

# This is the commit message apache#73:

CAMEL-11692: Set ClassLoader property on HBase configuration

# This is the commit message apache#74:

CAMEL-11666 - Camel Hazelcast Queue Consumer implementation

# This is the commit message apache#75:

CAMEL-11666 - Fixed CS and regen docs

# This is the commit message apache#76:

CAMEL-11666 - Improved docs

# This is the commit message apache#77:

CAMEL-11697 - S3 Consumer: If maxMessagesPerPoll is greater than 50 consumer fails to poll objects from bucket

# This is the commit message apache#78:

CAMEL-11697 - Updated docs

# This is the commit message apache#79:

CAMEL-9608 following up to take care of sharedEntityManager

# This is the commit message apache#80:

CAMEL-11697 - S3 Consumer: If maxMessagesPerPoll is greater than 50 consumer fails to poll objects from bucket - Set the maxConnections equals to default value + maxMessagesPoll

# This is the commit message apache#81:

CAMEL-8010:Locking the critical section to avoid race condition if AggregateTimeOutChecker also completes at the same time as Recover task

# This is the commit message apache#82:

CAMEL-8010:Included onSubmitCompletion in the lock section to prevent race condiditon

# This is the commit message apache#83:

CAMEL-8010:Included onSubmitCompletion in the lock section to prevent race condiditon

# This is the commit message apache#84:

CAMEL-8010:Reverted previous push since AggregatorLockingTest failed

# This is the commit message apache#85:

CAMEL-8010:Fixed checkstyle

# This is the commit message apache#86:

CAMEL-11645 - Add pattern exclusion mechanism similar to the one provided by the camel-zipkin component

# This is the commit message apache#87:

CAMEL-11701 - Camel-AWS S3: Use AmazonS3ClientBuilder instead of different constructors

# This is the commit message apache#88:

ComponentExtension : allow to unwrap to concrete extension.

# This is the commit message apache#89:

MetaDataExtension : allow to retrieve attributes directly

# This is the commit message apache#90:

CAMEL-11703 - Camel-AWS: Use builders instead of different constructors - AWS CloudWatch

# This is the commit message apache#91:

CAMEL-11703 - Camel-AWS: Use builders instead of different constructors - AWS DynamoDB

# This is the commit message apache#92:

CAMEL-11703 - Camel-AWS: Use builders instead of different constructors - AWS EC2

# This is the commit message apache#93:

CAMEL-11703 - Camel-AWS: Use builders instead of different constructors - AWS SimpleDB

# This is the commit message apache#94:

CAMEL-11703 - Camel-AWS: Use builders instead of different constructors - AWS SimpleEmail

# This is the commit message apache#95:

CAMEL-11703 - Camel-AWS: Use builders instead of different constructors - AWS SNS

# This is the commit message apache#96:

CAMEL-11703 - Camel-AWS: Use builders instead of different constructors - AWS SQS

# This is the commit message apache#97:

CAMEL-11703 - Camel-AWS: Use builders instead of different constructors - AWS SWF

# This is the commit message apache#98:

Upgrade Weld3 to version 3.0.1.Final

# This is the commit message apache#99:

CAMEL-11705 - Camel-Caffeine: ExpireAfterAccess set two times instead of ExpireAfterWrite

# This is the commit message apache#100:

CAMEL-ASN1 - ASN.1 Data Format Component with Bouncy Castle-bcprov-jdk15on and openmuc-jasn1

# This is the commit message apache#101:

CAMEL-11612-updated per code review

# This is the commit message apache#102:

CAMEL-11612-code review fixes

# This is the commit message apache#103:

CAMEL-11612 - rebase
ffang pushed a commit to ffang/camel that referenced this pull request Aug 31, 2017
@zregvart
Merge pull request apache#57 from zregvart/2.17.0.redhat-6-3-x
c8cd7d8 
ENTESB-4974  Enhance Camel Salesforce Component To Support Durable PushTopics and REST APIs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@mdarcemont @dhirajsb @davsclaus