CAMEL-18099: Adding Azure Identity authentication support #7615
Conversation
…eBlob component. - organized imports.
|
|
|
❌ Finished component verification: 1 component(s) test failed out of 1 component(s) tested |
…eBlob component. - organized imports for checkstyle import order.
There was a problem hiding this comment.
Just minor findings, looks good overall. I think it should be nice to add some examples of configuration in the src/main/docs/*.adoc file for this component. Also I do think we should do the same for all the Azure components we have. Thanks a lot for this PR.
...-storage-blob/src/main/java/org/apache/camel/component/azure/storage/blob/BlobComponent.java
Outdated
Show resolved
Hide resolved
...storage-blob/src/main/java/org/apache/camel/component/azure/storage/blob/CredentialType.java
Outdated
Show resolved
Hide resolved
...storage-blob/src/main/java/org/apache/camel/component/azure/storage/blob/CredentialType.java
Outdated
Show resolved
Hide resolved
...storage-blob/src/main/java/org/apache/camel/component/azure/storage/blob/CredentialType.java
Outdated
Show resolved
Hide resolved
|
❌ Finished component verification: 1 component(s) test failed out of 1 component(s) tested |
PR Review, fixing * imports to fully qualified.
PR Review, Java convention for Enums
PR Review, Java convention for Enums
PR Review, Java convention for Enums (missed ref in doc)
|
❌ Finished component verification: 1 component(s) test failed out of 1 component(s) tested |
|
@yuhusolutions can you please check the tests? |
- Ran mvm formatter:format - Fixed tests to specify CredentialType - Fixed regression in clientFactory
|
✔️ Finished component verification: 0 component(s) test failed out of 1 component(s) tested |
Hi there, this PR add supports for Azure Identity authentication for the AzureBlob component.
It changes the default behavior from "shared key" (discouraged) to AzureIdentity authentication.
Added deps to the pom.xml for azure-identity, and refactored the boiler plate code to support other types of token auth if need be for the future (e.g. SAS token). From now on, the authentication type needs to be specified to switch from default.
Tested existing and new ways to authenticate, with the existing test and using a consumer & producer route.
Could not find regression.
Note that I updated the doc accordingly, part of it seems to be generated.
Let me know your comments.
Thanks.
[CAMEL-XXX] Fixes bug in camel-file component, where you replaceCAMEL-XXXwith the appropriate JIRA issue CAMEL-18099.mvn clean install -Psourcecheckin your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.Below are the contribution guidelines:
https://github.com/apache/camel/blob/main/CONTRIBUTING.md