Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAMEL-18131 - Adding health check to test connectivity to aws2-athena #8392

Merged
merged 3 commits into from Sep 20, 2022

Conversation

rhuan080
Copy link
Contributor

@rhuan080 rhuan080 commented Sep 19, 2022

Signed-off-by: Rhuan Rocha rhuan080@gmail.com

CAMEL-18131 - Adding health check to test connectivity

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • If you're unsure, you can format the pull request title like [CAMEL-XXX] Fixes bug in camel-file component, where you replace CAMEL-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Psourcecheck in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
    Below are the contribution guidelines:
    https://github.com/apache/camel/blob/main/CONTRIBUTING.md

Signed-off-by: Rhuan Rocha <rhuan080@gmail.com>

CAMEL-18131 - Adding health check to test conectivity

Signed-off-by: Rhuan Rocha <rhuan080@gmail.com>

CAMEL-18131 - Adding health check to test conectivity

Signed-off-by: Rhuan Rocha <rhuan080@gmail.com>

CAMEL-18131 - Adding health check to test conectivity

Signed-off-by: Rhuan Rocha <rhuan080@gmail.com>
@github-actions
Copy link
Contributor

⚠️ This PR changes Camel components and will be tested automatically.

@github-actions
Copy link
Contributor

✔️ Finished component verification: 0 component(s) test failed out of 1 component(s) tested

Copy link
Contributor

@oscerd oscerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, have a look at the AWS S3 health check. You need to consider also the possibility of using default credentials provider or passing a custom client instance. This covers only accessKey/secretKey/region approach.

…ing a custom client instance

Signed-off-by: Rhuan Rocha <rhuan080@gmail.com>
@rhuan080
Copy link
Contributor Author

Hi @oscerd,

Done!

…ing a custom client instance

Signed-off-by: Rhuan Rocha <rhuan080@gmail.com>
@github-actions
Copy link
Contributor

❌ Finished component verification: 1 component(s) test failed out of 1 component(s) tested

@github-actions
Copy link
Contributor

✔️ Finished component verification: 0 component(s) test failed out of 1 component(s) tested

@oscerd oscerd merged commit 7e3f81e into apache:main Sep 20, 2022
@oscerd
Copy link
Contributor

oscerd commented Sep 20, 2022

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants