Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CARBONDATA-2316] Executor task is failed but UI shows success issue is fixed … #2142

Closed
wants to merge 1 commit into from
Closed

[CARBONDATA-2316] Executor task is failed but UI shows success issue is fixed … #2142

wants to merge 1 commit into from

Conversation

rahulk2
Copy link
Contributor

@rahulk2 rahulk2 commented Apr 6, 2018 •
edited
Loading

  • Any interfaces changed? No

  • Any backward compatibility impacted? No

  • Document update required? No

  • Testing done UT And FT success report is sufficient . offline verified .

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. NA

@CarbonDataQA
Copy link

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4852/

@CarbonDataQA
Copy link

Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3630/

@ravipesala
Copy link
Contributor

SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4321/

@rahulk2 rahulk2 changed the title [CARBONDATA-2316] [WIP] Executor task is failed but UI shows success issue is fixed … [CARBONDATA-2316] Executor task is failed but UI shows success issue is fixed … Apr 9, 2018
@CarbonDataQA
Copy link

Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3673/

@CarbonDataQA
Copy link

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4896/

@ravipesala
Copy link
Contributor

SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4365/

manishgupta88
manishgupta88 suggested changes Apr 11, 2018
View reviewed changes
processing/pom.xml Outdated
<groupId>org.apache.spark</groupId>
<artifactId>spark-core_${scala.binary.version}</artifactId>
<version>${spark.version}</version>
</dependency>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this dependency. Do not add spark dependency in processing layer until and unless really required

processing/src/main/java/org/apache/carbondata/processing/merger/AbstractResultProcessor.java Outdated
@@ -37,7 +39,7 @@
* @param resultIteratorList
* @return
*/
public abstract boolean execute(List<RawResultIterator> resultIteratorList);
public abstract boolean execute(List<RawResultIterator> resultIteratorList) throws SparkException;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can only throw the exception that is sufficient

...ing/src/main/java/org/apache/carbondata/processing/merger/CompactionResultSortProcessor.java Outdated
@@ -165,8 +168,12 @@ public boolean execute(List<RawResultIterator> resultIteratorList) {
readAndLoadDataFromSortTempFiles();
}
isCompactionSuccess = true;
} catch (Exception e) {
} catch (BadRecordFoundException e) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BadRecordFoundException will never come in case of compaction so remove this catch block

...ing/src/main/java/org/apache/carbondata/processing/merger/CompactionResultSortProcessor.java Outdated
LOGGER.error(e, "Compaction failed: " + e.getMessage());
throw new SparkException(e.getMessage());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove throwing sparkException from everywhere in the code

processing/src/main/java/org/apache/carbondata/processing/merger/RowResultMergerProcessor.java Outdated
@@ -157,10 +160,15 @@ public boolean execute(List<RawResultIterator> resultIteratorList) {
this.dataHandler.finish();
}
mergeStatus = true;
} catch (Exception e) {
} catch (BadRecordFoundException e) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this catch block

@CarbonDataQA
Copy link

Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4935/

@CarbonDataQA
Copy link

Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3716/

@ravipesala
Copy link
Contributor

SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4396/

@CarbonDataQA
Copy link

Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3720/

@CarbonDataQA
Copy link

Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4939/

@CarbonDataQA
Copy link

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4942/

@CarbonDataQA
Copy link

Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3723/

@ravipesala
Copy link
Contributor

SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4400/

@manishgupta88
Copy link
Contributor

LGTM

@asfgit asfgit closed this in f1d8464 Apr 11, 2018
akashrn5 pushed a commit to akashrn5/incubator-carbondata that referenced this pull request Apr 12, 2018
@rahulk2 @akashrn5
[CARBONDATA-2316] Executor task is failed but UI shows success issue …
e3d01f8 
…is fixed

Executor task is failed but UI shows success issue is fixed for compaction

This closes apache#2142
anubhav100 pushed a commit to anubhav100/incubator-carbondata that referenced this pull request Jun 22, 2018
@rahulk2 @anubhav100
[CARBONDATA-2316] Executor task is failed but UI shows success issue …
2c3b99c 
…is fixed

Executor task is failed but UI shows success issue is fixed for compaction

This closes apache#2142
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manishgupta88 manishgupta88 manishgupta88 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rahulk2 @CarbonDataQA @ravipesala @manishgupta88