[CARBONDATA-2534][MV] Fix substring expression not working in MV creation #2476
Conversation
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6989/ |
|
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5767/ |
|
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5744/ |
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7092/ |
ravipesala
force-pushed
the
mv-2534
branch
3 times, most recently
from
0956202
to
5189f4f
Compare
| @@ -119,7 +119,12 @@ object MVHelper { | |||
| } | |||
|
|
|||
| def updateColumnName(attr: Attribute): String = { | |||
| val name = attr.name.replace("(", "_").replace(")", "").replace(" ", "_").replace("=", "") | |||
| val name = | |||
| attr.name.replace("(", "_"). | |||
|
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5851/ |
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7194/ |
|
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5969/ |
|
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5860/ |
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7235/ |
|
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6008/ |
|
retest sdv please |
|
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5950/ |
|
LGTM |
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7414/ |
|
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6178/ |
…tion Problem: The column generated when subquery expression column present is wrong while creating of MV table. Solution: Corrected the column name by removing special characters. This closes #2476
This PR depends on #2453
Problem: The column generated when subquery expression column present is wrong while creating of MV table.
Solution: Corrected the column name by removing special characters.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
Any interfaces changed?
Any backward compatibility impacted?
Document update required?
Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.